Modernize testing #294
Merged
Modernize testing #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we would still test two different requirements, a very old 2.10, and a relatively new ansible. There is no reason to maintain the 2.10 testing framework, we can simply modernize the whole system. This allowed us to bump ansible-lint, and adopt the new lint recommendations, which are adapted here. I now also moved back to use Vagrant again, since the molecule docker is AGAIN broken. Fixes: #271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we would still test two different requirements, a very old 2.10, and a relatively new ansible.
There is no reason to maintain the 2.10 testing framework, we can simply modernize the whole system.
This allowed us to bump ansible-lint, and adopt the new lint recommendations, which are adapted here.
I now also moved back to use Vagrant again, since the molecule docker is AGAIN broken... But did not include it in gating, as virtualbox and vagrant isn't available there.
Fixes: #271