Feature/metabase 48

[Nikos410]

No description provided.

[mat02]

Thank you for your hard work 👏
It looks like change to HSQL 2 brought some more breaking changes, i.e. :modifiers not longer exists:
https://github.com/seancorfield/honeysql/blob/7a7a01eeaaa56b6e00574feb63be9c09e782f2c2/doc/differences-from-1-x.md?plain=1#L166

This breaks FIRST and SKIP implementation in apply-top-level-clause:

metabase-firebird-driver/src/metabase/driver/firebird.clj

Line 83 in a240bf2

(defmethod sql.qp/apply-top-level-clause [:firebird :limit] [_ _ honeysql-form {value :limit}]

metabase-firebird-driver/src/metabase/driver/firebird.clj

Line 87 in a240bf2

(defmethod sql.qp/apply-top-level-clause [:firebird :page] [_ _ honeysql-form {{:keys [items page]} :page}]

Could you please look into possible workaround?

[Nikos410]

Hey @mat02 thanks for that link! That changes were not mentioned in die Metabase Upgrade docs, so I missed them - I will look into that! Still, I find it weird that the driver is working fine for us and only some people are experiencing problems... Best Nikos -------- Original-Nachricht -------- Am 7. März 2024, 11:25, schrieb Mateusz Knapik :

…

Thank you for your hard work 👏 It looks like change to HSQL 2 brought some more breaking changes, i.e. :modifiers not longer exists: https://github.com/seancorfield/honeysql/blob/7a7a01eeaaa56b6e00574feb63be9c09e782f2c2/doc/differences-from-1-x.md?plain=1#L166 This breaks FIRST and SKIP implementation in apply-top-level-clause: https://github.com/evosec/metabase-firebird-driver/blob/a240bf29229f2ad7e6467c275680000ba06dd509/src/metabase/driver/firebird.clj#L83 https://github.com/evosec/metabase-firebird-driver/blob/a240bf29229f2ad7e6467c275680000ba06dd509/src/metabase/driver/firebird.clj#L86 Could you please look into possible workaround? — Reply to this email directly, [view it on GitHub](#21 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AE7I4UROFJR6G5IPTCV2KKLYXA6CBAVCNFSM6AAAAABB42TGNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTGIYDGNBRGE). You are receiving this because you authored the thread.Message ID: ***@***.***>

[mat02]

Maybe this is related to the FB version. We run 3.0 in SuperServer mode (I believe this is the same as you are, at least I think I saw it mentioned somewhere), but only stumbled on this problem with :modifiers keyword in in some specific questions, where Metabase automatically applies top-level clause to limit number of rows (not exactly sure why.

Unfortunately, I am not familiar with Clojure (nor other functional languages) enough to fix this myself :/