Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Desktop App Build #8650

Merged
merged 13 commits into from
Dec 30, 2024
Merged

[Fix] Desktop App Build #8650

merged 13 commits into from
Dec 30, 2024

Conversation

rahul-rocket
Copy link
Collaborator

@rahul-rocket rahul-rocket commented Dec 30, 2024

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Summary by CodeRabbit

Release Notes

  • Dependency Management

    • Updated package dependencies to use local file references instead of versioned dependencies
    • Simplified path resolution for UI core modules
  • Configuration Updates

    • Removed legacy ESLint and Jest configuration files
    • Added new ESLint configuration files with enhanced JSON parsing
    • Updated TypeScript compiler options across multiple packages
  • Module Enhancements

    • Improved plugin module initialization and lifecycle management
    • Added Swagger API documentation configuration
    • Enhanced dependency injection in plugin modules
  • Build and Development

    • Adjusted build configurations for various packages
    • Enforced consistent file naming conventions
    • Streamlined project structure and module imports

Copy link
Contributor

coderabbitai bot commented Dec 30, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces comprehensive changes across multiple packages in the Gauzy project, focusing on restructuring dependency management and configuration files. The modifications primarily involve updating package.json files to use local file dependencies instead of versioned dependencies, removing and updating ESLint and TypeScript configuration files, and making subtle adjustments to module and project configurations. The changes aim to streamline the project's dependency resolution and improve the overall project structure.

Changes

File Change Summary
apps/desktop-timer/src/package.json Replaced versioned @gauzy/desktop-core dependency with local file reference
apps/desktop/src/index.ts Added ApiConfig interface, updated getApiBaseUrl function with improved configuration
apps/desktop/src/package.json Updated workspace paths and dependencies, added local file references for various packages
apps/server-api/src/package.json Modified workspace paths and dependencies, added local file references
apps/server/src/package.json Updated dependencies, added local file references for various packages
Multiple packages Removed .eslintrc.json, added eslint.config.js
Multiple packages Removed jest.config.ts
Multiple packages Updated tsconfig.json, removed module: commonjs option

Sequence Diagram

sequenceDiagram
    participant App as Application
    participant Config as Configuration Module
    participant Deps as Dependency Resolver

    App->>Config: Request Configuration
    Config->>Deps: Resolve Local Dependencies
    Deps-->>Config: Return Local Package References
    Config-->>App: Provide Updated Configuration
Loading

Possibly related PRs

Suggested labels

FIX

Suggested reviewers

  • rahul-rocket

Poem

🐰 Hopping through configs with glee,
Dependencies dancing, now locally free!
Package paths shifting, a refactoring spree,
Simplifying imports, setting modules free!
CodeRabbit's magic, clean and neat! 🔧✨

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 027b1a9 and 5984434.

📒 Files selected for processing (46)
  • apps/desktop-timer/src/package.json (1 hunks)
  • apps/desktop/src/index.ts (2 hunks)
  • apps/desktop/src/package.json (2 hunks)
  • apps/server-api/src/package.json (2 hunks)
  • apps/server/src/package.json (2 hunks)
  • packages/auth/.eslintrc.json (0 hunks)
  • packages/auth/eslint.config.js (1 hunks)
  • packages/auth/jest.config.ts (0 hunks)
  • packages/auth/project.json (1 hunks)
  • packages/auth/tsconfig.json (1 hunks)
  • packages/common/.eslintrc.json (0 hunks)
  • packages/common/eslint.config.js (1 hunks)
  • packages/common/jest.config.ts (0 hunks)
  • packages/common/tsconfig.json (1 hunks)
  • packages/common/tsconfig.lib.json (1 hunks)
  • packages/config/.eslintrc.json (0 hunks)
  • packages/config/eslint.config.js (1 hunks)
  • packages/config/jest.config.ts (0 hunks)
  • packages/config/tsconfig.json (1 hunks)
  • packages/contracts/.eslintrc.json (0 hunks)
  • packages/contracts/eslint.config.js (1 hunks)
  • packages/contracts/jest.config.ts (0 hunks)
  • packages/contracts/project.json (1 hunks)
  • packages/contracts/tsconfig.json (1 hunks)
  • packages/contracts/tsconfig.lib.json (1 hunks)
  • packages/core/src/lib/bootstrap/bootstrap.module.ts (1 hunks)
  • packages/core/src/lib/bootstrap/index.ts (3 hunks)
  • packages/desktop-lib/.eslintrc.json (0 hunks)
  • packages/desktop-lib/eslint.config.js (1 hunks)
  • packages/desktop-lib/jest.config.ts (0 hunks)
  • packages/desktop-lib/package.json (1 hunks)
  • packages/desktop-lib/project.json (1 hunks)
  • packages/desktop-lib/src/lib/desktop-ipc.ts (1 hunks)
  • packages/desktop-lib/tsconfig.json (1 hunks)
  • packages/desktop-window/.eslintrc.json (0 hunks)
  • packages/desktop-window/eslint.config.js (1 hunks)
  • packages/desktop-window/jest.config.ts (0 hunks)
  • packages/desktop-window/project.json (1 hunks)
  • packages/desktop-window/tsconfig.json (1 hunks)
  • packages/desktop-window/tsconfig.lib.json (1 hunks)
  • packages/plugin/.eslintrc.json (0 hunks)
  • packages/plugin/eslint.config.js (1 hunks)
  • packages/plugin/jest.config.ts (0 hunks)
  • packages/plugin/src/lib/plugin.module.ts (2 hunks)
  • packages/plugin/tsconfig.json (1 hunks)
  • tsconfig.json (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

nx-cloud bot commented Dec 30, 2024

View your CI Pipeline Execution ↗ for commit 5984434.

Command Status Duration Result
nx build gauzy -c=production --prod --verbose ✅ Succeeded 4m 19s View ↗
nx build api -c=production --prod ✅ Succeeded 1m 7s View ↗
nx build desktop-ui-lib --configuration=develop... ✅ Succeeded 31s View ↗
nx build desktop-ui-lib --configuration=production ✅ Succeeded 28s View ↗
nx build plugin-integration-wakatime ✅ Succeeded 4s View ↗
nx build desktop-lib ✅ Succeeded <1s View ↗
nx build desktop-window ✅ Succeeded <1s View ↗
nx build desktop-core ✅ Succeeded <1s View ↗
Additional runs (48) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2024-12-30 13:43:03 UTC

@evereq evereq marked this pull request as ready for review December 30, 2024 14:48
@evereq evereq merged commit 9cdaecd into develop Dec 30, 2024
14 of 17 checks passed
@evereq evereq deleted the fix/desktop-app-build branch December 30, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants