Skip to content

Commit

Permalink
Merge pull request #8809 from ever-co/fix/alter-entity-subscription-e…
Browse files Browse the repository at this point in the history
…ntity

[Refactor] Rename "Subscription" to "EntitySubscription"
  • Loading branch information
rahul-rocket authored Feb 28, 2025
2 parents 590cf1c + cbd1a57 commit 26f568c
Show file tree
Hide file tree
Showing 51 changed files with 954 additions and 475 deletions.
2 changes: 1 addition & 1 deletion packages/contracts/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export * from './lib/shared-types';
export * from './lib/skill-entity.model';
export * from './lib/sms.model';
export * from './lib/social-account.model';
export * from './lib/subscription.model';
export * from './lib/entity-subscription.model';
export * from './lib/tag.model';
export * from './lib/task-estimation.model';
export * from './lib/task-linked-issue.model';
Expand Down
18 changes: 18 additions & 0 deletions packages/contracts/src/lib/entity-subscription.model.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { IBasePerEntityType, OmitFields } from './base-entity.model';
import { IEmployeeEntityInput } from './employee.model';

export interface IEntitySubscription extends IBasePerEntityType, IEmployeeEntityInput {
type: EntitySubscriptionTypeEnum;
}

export enum EntitySubscriptionTypeEnum {
MANUAL = 'manual',
MENTION = 'mention',
ASSIGNMENT = 'assignment',
COMMENT = 'comment',
CREATED_ENTITY = 'created-entity'
}

export interface IEntitySubscriptionCreateInput extends OmitFields<IEntitySubscription> {}

export interface IEntitySubscriptionFindInput extends Partial<IEntitySubscription> {}
22 changes: 0 additions & 22 deletions packages/contracts/src/lib/subscription.model.ts

This file was deleted.

4 changes: 2 additions & 2 deletions packages/core/src/lib/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ import { ApiCallLogModule } from '../api-call-log/api-call-log.module'; // Globa
import { TaskViewModule } from '../tasks/views/view.module';
import { ResourceLinkModule } from '../resource-link/resource-link.module';
import { MentionModule } from '../mention/mention.module';
import { SubscriptionModule } from '../subscription/subscription.module';
import { EntitySubscriptionModule } from '../entity-subscription/entity-subscription.module';
import { DashboardModule } from '../dashboard/dashboard.module';
import { DashboardWidgetModule } from '../dashboard/dashboard-widget/dashboard-widget.module';
import { TenantApiKeyModule } from '../tenant-api-key/tenant-api-key.module';
Expand Down Expand Up @@ -469,7 +469,7 @@ if (environment.THROTTLE_ENABLED) {
TaskViewModule,
ResourceLinkModule,
MentionModule,
SubscriptionModule,
EntitySubscriptionModule,
DashboardModule,
DashboardWidgetModule,
EmployeeNotificationModule,
Expand Down
11 changes: 6 additions & 5 deletions packages/core/src/lib/comment/comment.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ import { BadRequestException, Injectable, NotFoundException } from '@nestjs/comm
import { UpdateResult } from 'typeorm';
import {
BaseEntityEnum,
EntitySubscriptionTypeEnum,
IComment,
ICommentCreateInput,
ICommentUpdateInput,
ID,
SubscriptionTypeEnum
ID
} from '@gauzy/contracts';
import { TenantAwareCrudService } from './../core/crud';
import { RequestContext } from '../core/context';
import { CreateSubscriptionEvent } from '../subscription/events';
import { CreateEntitySubscriptionEvent } from '../entity-subscription/events';
import { EmployeeService } from '../employee/employee.service';
import { MentionService } from '../mention/mention.service';
import { Comment } from './comment.entity';
Expand Down Expand Up @@ -83,10 +83,11 @@ export class CommentService extends TenantAwareCrudService<Comment> {

// Subscribe the comment creator to the entity.
this._eventBus.publish(
new CreateSubscriptionEvent({
new CreateEntitySubscriptionEvent({
entity: input.entity,
entityId: input.entityId,
type: SubscriptionTypeEnum.COMMENT,
employeeId,
type: EntitySubscriptionTypeEnum.COMMENT,
organizationId: comment.organizationId,
tenantId: comment.tenantId
})
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/lib/core/entities/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ import {
Screenshot,
Skill,
SocialAccount,
Subscription,
EntitySubscription,
Tag,
TagType,
Task,
Expand Down Expand Up @@ -292,7 +292,7 @@ export const coreEntities = [
Screenshot,
Skill,
SocialAccount,
Subscription,
EntitySubscription,
Tag,
TagType,
Task,
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/lib/core/entities/internal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export * from '../../resource-link/resource-link.entity';
export * from '../../role-permission/role-permission.entity';
export * from '../../role/role.entity';
export * from '../../skills/skill.entity';
export * from '../../subscription/subscription.entity';
export * from '../../entity-subscription/entity-subscription.entity';
export * from '../../tags/tag.entity';
export * from '../../tag-type/tag-type.entity';
export * from '../../tasks/daily-plan/daily-plan.entity';
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/lib/core/seeds/seeder.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { LanguagesEnum } from '@gauzy/contracts';
import { DatabaseModule } from './../../database/database.module';
import { ActivityLogModule } from '../../activity-log/activity-log.module';
import { MentionModule } from '../../mention/mention.module';
import { SubscriptionModule } from '../../subscription/subscription.module';
import { EntitySubscriptionModule } from '../../entity-subscription/entity-subscription.module';
import { SeedDataService } from './seed-data.service';

/**
Expand Down Expand Up @@ -42,7 +42,7 @@ export class SeederModule {
DatabaseModule,
ActivityLogModule,
MentionModule,
SubscriptionModule,
EntitySubscriptionModule,
...getDynamicPluginsModules()
]
};
Expand Down
Loading

0 comments on commit 26f568c

Please sign in to comment.