(CSS) Fix nesting lowering with complex sub selectors #4037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #3620.
When nesting is lowered (for example when the target is Chrome 117) the current version of esbuild will transform this:
into this (playground link)
which is wrong because
.parent > :is(.b1 > .b2)
is semantically different from.parent > .b1 > .b2
.With the change in this PR the output will instead be this:
I have added a test for this as well. The fix is in the first pass of the
lowerNestingInRuleWithContext
method. When a nested complex selector is sufficiently complex (has another combinator) the transformation will be disabled.