This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Added RGBD interface #6
Open
lfrschkn
wants to merge
13
commits into
ethz-asl:master
Choose a base branch
from
lfrschkn:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tested on 16.04+Kinetic and 14.04+Jade - no extensive tests, just checked if orbslam2 gets image streams and produces estimates, quality and properness of estimates not tested.
- for rgbd up to now - needs orb_slam_2_catkin to use lfrschkn/ORB_SLAM2 fork due to Map needed to be public inspired by https://github.com/idsc-frazzoli/ardrone_testbed
publishes true if orb slam 2 is running a global bundle adjustement. Meaning it is in localization mode and a bigger map update is to be expected
orb slam 2 GBA publisher
Hi, @lfrschkn Sorry to bother, but as for the interface_rgbd.cpp in the last "view off"version, there are three lines as follow.
I guess this suggests we need to modify system.h and system.cc. But how to modify it when these two files are build from orb_slam2_catkin version? Directly modify the two files in catkin_ws/build and catkin_ws/devel? Besides, what code should we add in these three functions in system.cc? Thanks in advance! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
comments: