Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow initializing with full quaternion. #182

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rikba
Copy link
Contributor

@rikba rikba commented May 11, 2020

This PR exposes initialization using the full orientation. This becomes useful when starting MSF with an IMU that is not perfectly aligned with the inertial frame. May solve #169 and others.

Remarks:

  • This PR does not solve the issue that MSF is initialized from parameter server instead of the first message arriving which would be more convenient in my opinion. In our case we wrote an extra node that reads the first IMU orientation and GPS position from ROS messages and then writes it to dynamic reconfigure. I can share this node if desired.
  • This PR removes initialization from yaw only. If there is a neat or preferred way to preserve backwards compatibility we can implement that. Let me know.

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@clanegge
Copy link
Contributor

Looks good. Would maybe make sense to change it for the other sensors as well (PositionPoseSensor and SphericalPositionSensor), to stay consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants