feat(integration.yaml): use env vars for beacon node URLs

feat: remove exportloopref linter The integration workflow now uses environment variables to configure beacon node URLs, and the exportloopref linter has been removed from the golangci configuration.
ethpandaops · Feb 21, 2025 · 5852cd5 · 5852cd5
1 parent 6379fae
commit 5852cd5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/integration.yaml b/.github/workflows/integration.yaml
@@ -16,6 +16,9 @@ jobs:
         network: [mainnet]
     runs-on: ubuntu-latest
     timeout-minutes: 10
+    env:
+      MAINNET_BEACON_API_URL: ${{ secrets.MAINNET_BEACON_API_URL }}
+      HOLESKY_BEACON_API_URL: ${{ secrets.HOLESKY_BEACON_API_URL }}
     steps:
       - uses: actions/checkout@v3
       - name: Print details
@@ -28,5 +31,4 @@ jobs:
         with:
           consensus: ${{ matrix.consensus }}
           network: ${{ matrix.network }}
-          beacon_node_url: ${{ matrix.network == 'mainnet' && secrets.MAINNET_BEACON_API_URL || secrets.HOLESKY_BEACON_API_URL }}
-
+          beacon_node_url: ${{ matrix.network == 'mainnet' && env.MAINNET_BEACON_API_URL || env.HOLESKY_BEACON_API_URL }}
diff --git a/.golangci.yml b/.golangci.yml
@@ -24,7 +24,6 @@ linters:
     - dogsled
     - dupl
     - errcheck
-    - exportloopref
     - goconst
     - gocritic
     - gofmt
-Original file line number
+Diff line change
@@ Expand Up / @@ -24,7 +24,6 @@ linters: @@
         - dogsled
         - dupl
         - errcheck
-        - exportloopref
         - goconst
         - gocritic
         - gofmt
@@ Expand Down @@