This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
rename/pubsub-topicfilter #2170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another name that could be used would be Subscription. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this PR is probably a bit controversial, therefore I fully understand if it is not accepted. However, the fact that PSS has something called pubsub is rather misleading and therefore I have decided to rename it to
TopicFilterthis seems more accurate from my current understanding of the code.PubSub would imply that any peer can subscribe to a specific topic and receive messages on it, and the creator of that topic can then send messages to it and all peers receive it. However this is not what I see in the code, instead a user registers that they want to subscribe to a topic and a sender can send a peer a message with that topic in it so that the peer actually receives it and does not ignore it.