Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncHTTPProvider extra dependencies #2136

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ediskandarov
Copy link
Contributor

@ediskandarov ediskandarov commented Sep 8, 2021

What was wrong?

Installation of web.py python package by default required aiohttp in dependencies.

Async HTTP provider is not required until you specifically write async code(which is not a general case).

Thus it would be rational to move this dependency to extras.

How was it fixed?

Moved aiohttp to extra requirements.

Todo:

Cute Animal Picture

photo-1605206731460-0bbdfadf9808

@ediskandarov
Copy link
Contributor Author

@kclowes @fselmo please review

@ediskandarov
Copy link
Contributor Author

if there any way to push this forward?

@kclowes
Copy link
Collaborator

kclowes commented Sep 13, 2021

This seems like a reasonable change to me @emcpow2, especially since async is not in a complete state yet. I'll do some manual testing and merge soon! Thanks!

@kclowes kclowes added this to In progress in kanban [experimental] Sep 13, 2021
@kclowes
Copy link
Collaborator

kclowes commented Sep 27, 2021

For some reason the full test suite wasn't running on the PR, so it looks like we have a few failures that need to be addressed. However, after playing with this a little bit, I'm inclined to close this PR because my gut is telling me that async will be the primary way that people use web3 in the future. @emcpow2 do you have a particular reason/use case to remove the dependency, other than keeping the dependencies slim?

@ediskandarov
Copy link
Contributor Author

Hey @kclowes . Yes, it's solely to keep dependencies as slim as possible.

Many projects will not welcome aiohttp in dependencies. (I have no attitude to the aiohttp itself, it just seems an overkill to explicitly require it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants