Make messages mandatory in errors #15671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors shown to the user should always have a message. One situation where it is not always the case now are unimplemented feature errors. Those used to be treated as asserts but often they can actually reach the user. This PR deals with them by either converting to asserts or adding a message. Then makes the message mandatory in
solUnimplemented()/solUnimplementedAssert()and in the error reporter.This partially addresses cases like #15669, which currently get properly reported but in a very confusing way.
I could probably convert many more of these to asserts but in cases where I wasn't sure I decided to err on the side of keeping them as is.