Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify readme in ossfuzz #14746

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

Subway2023
Copy link

According to the new readme instruction, Ossfuzz can be successfully compiled.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Copy link
Contributor

@bshastry bshastry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you once again!

@@ -6,10 +6,10 @@

We have multiple fuzzers, some based on string input and others on protobuf input. To build them, please do the following:

- Create a local docker image from `Dockerfile.ubuntu.clang.ossfuzz` in the `.circleci/docker` sub-directory. Please note that this step is likely to take at least an hour to complete. Therefore, it is recommended to do it when you are away from the computer (and the computer is plugged to power since we do not want a battery drain).
- Create a local docker image from `Dockerfile.ubuntu.clang.ossfuzz` in the `solidity/scripts/docker/buildpack-deps` sub-directory. Please note that this step is likely to take at least an hour to complete. Therefore, it is recommended to do it when you are away from the computer (and the computer is plugged to power since we do not want a battery drain). If the request fails, you can replace `gcr.io/oss-fuzz-base/base-clang:latest` with `registry.aliyuncs.com/oss-fuzz-base/base-clang:latest` in `Dockerfile.ubuntu.clang.ossfuzz`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Create a local docker image from `Dockerfile.ubuntu.clang.ossfuzz` in the `solidity/scripts/docker/buildpack-deps` sub-directory. Please note that this step is likely to take at least an hour to complete. Therefore, it is recommended to do it when you are away from the computer (and the computer is plugged to power since we do not want a battery drain). If the request fails, you can replace `gcr.io/oss-fuzz-base/base-clang:latest` with `registry.aliyuncs.com/oss-fuzz-base/base-clang:latest` in `Dockerfile.ubuntu.clang.ossfuzz`.
- Create a local docker image from `Dockerfile.ubuntu.clang.ossfuzz` in the `solidity/scripts/docker/buildpack-deps` sub-directory. Please note that this step is likely to take at least an hour to complete. Therefore, it is recommended to do it when you are away from the computer (and the computer is plugged to power since we do not want a battery drain). If the request fails, you can replace `gcr.io/oss-fuzz-base/base-clang:latest` with `registry.aliyuncs.com/oss-fuzz-base/base-clang:latest` in `Dockerfile.ubuntu.clang.ossfuzz`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants