Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed LearnEth can be launched with solidity unit testing plugin on the plugin manager #5494

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

skyler-coder
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Dec 14, 2024

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 58abccd

@Aniket-Engg Aniket-Engg requested a review from ryestew December 16, 2024 11:55
Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me.

@ryestew
Copy link
Collaborator

ryestew commented Dec 19, 2024

Thanks @skyler-coder!!!

@skyler-coder
Copy link
Contributor Author

you're welcome @ryestew

Copy link
Collaborator

@bunsenstraat bunsenstraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be done in the learneth plugin, not here. it would make this impossible to find back later

@skyler-coder
Copy link
Contributor Author

I checked through the learnEth plugin to see how I could add solidityUnitTesting to it but to no avail, I think this method I used is best to resolve this issue @bunsenstraat

@ryestew
Copy link
Collaborator

ryestew commented Dec 20, 2024

@bunsenstraat - while you might be right, clicking on the button to load Learneth in the Hometab activates LearnEth and Solidity Unit Testing. My issue is solved by this PR. If we don't merge this PR then the functionality of LearnEth for those who launch it from the Plugin Manager is compromised (or will continue to be compromised. Solving this through the LearnEth plugin, I fear will take a very long long time.

@skyler-coder
Copy link
Contributor Author

learnEth plugin does not have the permission to activate solidityUnitTesting plugin from a plugin call @bunsenstraat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants