-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed LearnEth can be launched with solidity unit testing plugin on the plugin manager #5494
base: master
Are you sure you want to change the base?
Fixed LearnEth can be launched with solidity unit testing plugin on the plugin manager #5494
Conversation
…he plugin manager
👷 Deploy request for remixproject pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me.
Thanks @skyler-coder!!! |
you're welcome @ryestew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be done in the learneth plugin, not here. it would make this impossible to find back later
I checked through the learnEth plugin to see how I could add solidityUnitTesting to it but to no avail, I think this method I used is best to resolve this issue @bunsenstraat |
@bunsenstraat - while you might be right, clicking on the button to load Learneth in the Hometab activates LearnEth and Solidity Unit Testing. My issue is solved by this PR. If we don't merge this PR then the functionality of LearnEth for those who launch it from the Plugin Manager is compromised (or will continue to be compromised. Solving this through the LearnEth plugin, I fear will take a very long long time. |
learnEth plugin does not have the permission to activate solidityUnitTesting plugin from a plugin call @bunsenstraat |
No description provided.