Use single conf.verb, warn users on zero-address use
#686
+136
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
warn-user-zero-addr
branch
from
04216a2 to
7b87a4e
Compare
msooseth
commented
Mar 18, 2025
Comment on lines
-301
to
-316
| passOutput :: VM t s -> UnitTestOptions s -> Text -> Text | ||
| passOutput vm UnitTestOptions { .. } testName = | ||
| let ?context = DappContext { info = dapp | ||
| , contracts = vm.env.contracts | ||
| , labels = vm.labels } | ||
| in let v = fromMaybe 0 verbose | ||
| in if (v > 1) then | ||
| mconcat | ||
| [ "Success: " | ||
| , fromMaybe "" (stripSuffix "()" testName) | ||
| , "\n" | ||
| , if (v > 2) then indentLines 2 (showTraceTree dapp vm) else "" | ||
| , indentLines 2 (formatTestLogs dapp.eventMap vm.logs) | ||
| , "\n" | ||
| ] | ||
| else "" |
There was a problem hiding this comment.
Not used anywhere, removing.
| @@ -59,7 +59,6 @@ testOpts solvers root buildOutput match maxIter allowFFI rpcinfo = do | |||
| , askSmtIters = 1 | |||
| , smtTimeout = Nothing | |||
| , solver = Nothing | |||
| , verbose = Just 1 | |||
There was a problem hiding this comment.
This is now conf and in cli.hs is set to by default 1. In API library use mode it's set to 0 by default.
msooseth
force-pushed
the
warn-user-zero-addr
branch
from
88870e5 to
7a75500
Compare
msooseth
changed the title
conf.verb, warn users on zero-address useconf.verb, warn users on zero-address use
msooseth
force-pushed
the
warn-user-zero-addr
branch
from
65a1161 to
d412468
Compare
Fixing up tests, strings
msooseth
force-pushed
the
warn-user-zero-addr
branch
from
d412468 to
5640901
Compare
blishko
reviewed
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This attempts to fix #671
We need to add a general verbosity flag, otherwise libraries that use us will have all sorts of junk printed on the console. Default is zero (is it's seamless for libraries), but we set it to 1 when running from the command line.
Note:
hevm test's--verbosityflag has been rolled into this, and it is now part ofApprather thanUnitTestOptions. This makes it more general, and makes it such that global options are truly in a single place (App).The
hevm test --verbose Xseems to have been broken. When it wasNothing, then nothing extra was printed, but when it wasJustthen stuff got printed. However, the description seems to have talked about a difference between1and2levels. This doesn't seem to exist. Now it's set to print more failure info when it's2or above. This preserves the default "silent" operation when running from the command line (where verbosity is 1 by default).Checklist