Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for #3744
The maximum encoded size of a node record is 300 bytes. (Source).
1. Field key
Reducing the
custoding_subnet_count
key tocsc
saves 19 bytes.2. Field value type
Switching the value of
custoding_subnet_count
fromSSZ uint64
tobig endian integer
has multiple advantages:128
(which is likely to be the case for the subnets count), then the value needs exactly one byte of storage when encoded. (Source).Switching the value of
custoding_subnet_count
fromSSZ uint64
tobig endian integer
saves 7 bytes.Total
Changing
1.
and2.
saves a total of19 + 7 = 26 bytes
.26 bytes
represents about8.5%
of the maximum size of an encoded node record.