Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Data Asset NFT #744

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

rockiecn
Copy link

The ERC outlines the minimally required interfaces and behavior for Data Asset NFT. It proposes a storage proof mechanism to ensure Data Asset NFT's integrity, and propose a new role, Reader, to Amplify Data Asset's value.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Nov 29, 2024

File EIPS/eip-7829.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

File ERCS/erc-7829.md

Requires 1 more reviewers from @g11tech, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title Add ERC-7921: Data Asset NFT Add ERC: Data Asset NFT Nov 29, 2024
@github-actions github-actions bot added the w-ci label Nov 29, 2024
ERCS/erc-7921.md Outdated Show resolved Hide resolved
ERCS/erc-7921.md Outdated Show resolved Hide resolved
rockiecn and others added 2 commits December 2, 2024 09:44
confirm change 7921 to 7829

Co-authored-by: Andrew B Coathup <[email protected]>
fix to 7829 in discussions-to

Co-authored-by: Andrew B Coathup <[email protected]>
@github-actions github-actions bot removed the w-ci label Dec 2, 2024
@github-actions github-actions bot added the w-ci label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

The commit b6f143d (as a parent of e5e3755) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci label Dec 2, 2024
@rockiecn rockiecn requested a review from abcoathup December 4, 2024 01:45
---
eip: 7829
title: Data Asset NFT
description: Bring Data Assets to NFTs and ensure the integrity of data asset NFTs through storage proof
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since "data asset" is already in the title, you could use your description to define what a data asset is.


Furthermore, to reduce storage costs, the NFT content is generally stored off-chain (IPFS, S3) or cross-chain storage (Arweave), and the link of NFT content is saved on-chain. Off-chain users can access the NFT content by visiting the link. However, on-chain contracts can not access the link to determine the status of the data, such as data loss, data tampering, or data expiration. These situations can lead to the data deviating from its actual value, but the NFT still exists on the chain, and the underlying copyright is still being sold in the market.

This proposal introduces Data Asset NFTs, which solve the dilemma of on-chain data assets by combining a modular data layer--DA (Data Availability).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This proposal introduces Data Asset NFTs, which solve the dilemma of on-chain data assets by combining a modular data layer--DA (Data Availability).
This proposal introduces Data Asset NFTs, which solve the dilemma of on-chain data assets by combining a modular data layer--Data Availability (DA).


The keywords “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY” and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.

### Every compliant data permission contract must implement the Interface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use shorter headings, and put the requirement in the body of the section.

}
```

The metadata schema for Data Asset NFTs is as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should mention what format the schema is in.

}
```

The Reader role should not involve changes in permissions, meaning that Readers cannot call functions such as Transfer, Approve, and SetReader.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put code snippets in backticks (`) throughout the document


The Reader role should not involve changes in permissions, meaning that Readers cannot call functions such as Transfer, Approve, and SetReader.

When Alice calls the Transfer function to transfer one of Alice's Data Asset NFTs to Bob:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean transfer (lowercase)?


## Copyright

Copyright and related rights waived via CC0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the exact waiver from the EIP template.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer SVGs if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants