Update ERC-7627: Move to Review #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ERCS/erc-7627.md
|
✅ All reviewers have approved. |
18 tasks
SamWilsn
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Your Rationale section is answering the question "why do we need this standard?". That kind of content belongs in the Motivation section, while the Rationale section should explain choices made within the proposal. My favourite analogy is:
Motivation: We need to build a shed because...
Rationale: We chose to paint the shed red because...
Everything else looks decent though!
18 tasks
The mapping is by user address and a unique key index.
|
As you mentioned, having a wallet store only one public key is not a good design. I modified the implementation to allow users to set multiple public keys and specify expiration times. |
SamWilsn
approved these changes
Sep 3, 2024
eip-review-bot
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: