Add ERC: Structured Data Clear Signing Format #4445
ci.yml
on: pull_request
Save PR Number
2s
HTMLProofer
8m 22s
Link Check
14s
CodeSpell
14s
EIP Walidator
8s
Markdown Linter
5s
Annotations
14 errors and 7 warnings
Markdown Linter
Process completed with exit code 1.
|
Markdown Linter
Unable to process file command 'env' successfully.
|
Markdown Linter
Invalid value. Matching delimiter not found 'EOF'
|
the first match of the given pattern must be a link:
ERCS/erc-7730.md#L20
error[markdown-link-first]: the first match of the given pattern must be a link
--> ERCS/erc-7730.md
|
20 | Properly validating a transaction on a Hardware Wallets screen (also known as Clear Signing) is a key element of good security practices for end users when interacting with any Blockchain. Unfortunately, most data to sign, even enriched with the data structure description (ABI or EIP-712 types) are not self-sufficient in terms of correctly displaying them to the user for review. Among other things:
|
= info: the pattern in question: `(?i)(?:eip|erc)-[0-9]+`
= help: see https://ethereum.github.io/eipw/markdown-link-first/
|
the first match of the given pattern must be a link:
ERCS/erc-7730.md#L127
error[markdown-link-first]: the first match of the given pattern must be a link
--> ERCS/erc-7730.md
|
127 | It also supports EIP-712 messages
|
= info: the pattern in question: `(?i)(?:eip|erc)-[0-9]+`
|
the first match of the given pattern must be a link:
ERCS/erc-7730.md#L285
error[markdown-link-first]: the first match of the given pattern must be a link
--> ERCS/erc-7730.md
|
285 | * The `schema` key is either an URL pointing to the EIP-712 schema or the json schema itself. An EIP 712 schema consists in the json document with just the `types` and `primaryType` keys of the message.
|
= info: the pattern in question: `(?i)(?:eip|erc)-[0-9]+`
|
the first match of the given pattern must be a link:
ERCS/erc-7730.md#L286
error[markdown-link-first]: the first match of the given pattern must be a link
--> ERCS/erc-7730.md
|
286 | * The `domain` key is the domain this file should be bound to. Each key in this `domain` binding MUST match the `domain` keys of the message. Note that the message can have more keys in its `domain` than those listed in the formatting file. An EIP-712 domain is a free-form list of keys, but those are very common to include:
|
= info: the pattern in question: `(?i)(?:eip|erc)-[0-9]+`
|
the first match of the given pattern must be a link:
ERCS/erc-7730.md#L337
error[markdown-link-first]: the first match of the given pattern must be a link
--> ERCS/erc-7730.md
|
337 | The `formats` key is an object containing the actual *field format specifications*. It is an object in which each sub-key is a specific contract call (for contracts) or a specific message type (for EIP-712) being described. The values are each a field formats specification
|
= info: the pattern in question: `(?i)(?:eip|erc)-[0-9]+`
|
the first match of the given pattern must be a link:
ERCS/erc-7730.md#L339
error[markdown-link-first]: the first match of the given pattern must be a link
--> ERCS/erc-7730.md
|
339 | * For EIP-712, the key name MUST be the type name being described. The keys MUST include at least the primary type of the message bound in the `context`.
|
= info: the pattern in question: `(?i)(?:eip|erc)-[0-9]+`
|
body has extra section(s):
ERCS/erc-7730.md#L359
error[markdown-order-section]: body has extra section(s)
--> ERCS/erc-7730.md
|
359 | ## Reference
|
::: ERCS/erc-7730.md
|
434 | ## Examples
|
= help: see https://ethereum.github.io/eipw/markdown-order-section/
|
proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`):
ERCS/erc-7730.md#L16
error[markdown-re-eip-dash]: proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`)
--> ERCS/erc-7730.md
|
16 | This specification defines a JSON format carrying additional information required to correctly display structured data to a human for review on a wallet screen, before signature by the wallet. In the current scope, structured data supported are smart contract calls in EVM transactions and EIP 712 structured messages.
|
= info: the pattern in question: `(?i)eip[\s]*[0-9]+`
= help: see https://ethereum.github.io/eipw/markdown-re-eip-dash/
|
proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`):
ERCS/erc-7730.md#L128
error[markdown-re-eip-dash]: proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`)
--> ERCS/erc-7730.md
|
128 | * Defined in [EIP 712](https://eips.ethereum.org/EIPS/eip-712)
|
= info: the pattern in question: `(?i)eip[\s]*[0-9]+`
|
proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`):
ERCS/erc-7730.md#L130
error[markdown-re-eip-dash]: proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`)
--> ERCS/erc-7730.md
|
130 | * An EIP 712 message is self contained, the signature is applied to the message itself.
|
= info: the pattern in question: `(?i)eip[\s]*[0-9]+`
|
HTMLProofer
Process completed with exit code 1.
|
Save PR Number
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@65d862660abb392b8c4a3d1195a2108db131dd05. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Markdown Linter
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
EIP Walidator
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
CodeSpell
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Link Check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
HTMLProofer
The following actions use a deprecated Node.js version and will be forced to run on node20: ruby/setup-ruby@55283cc23133118229fd3f97f9336ee23a179fcf. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "pr_number".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
pr_number
|
86 Bytes |
|