Update EIP-7702: Add checks for signatures in authorization lists #9632
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File
|
| @@ -100,6 +100,9 @@ following: | |||
| 3. `authority = ecrecover(msg, y_parity, r, s)` | |||
| * `msg = keccak(MAGIC || rlp([chain_id, address, nonce]))` | |||
| * `s` value must be less than or equal to `secp256k1n/2`, as specified in [EIP-2](./eip-2.md). | |||
| * `r` value must be less than `secp256k1n`. | |||
| * `s` and `r` values must be non-zero. | |||
| * `y_parity` value must be either `0` or `1`. | |||
There was a problem hiding this comment.
I think these checks are implicit in the ecrecover method but I think it is great to add this for clarification
There was a problem hiding this comment.
Yeah, they are implicit, but we have found bugs in some EL clients like Besu that accepted values diff from the expected ones, leading to a chain split. Because of that, I think being more verbose here could be helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some checks that are being done by all EL clients to the signature values of authorization lists, which are not stated in the EIP. As such, developers following the spec may have issues, as they would be working with signatures that are invalid at the EL layer. As an example, see Geth (this is called when checking the auth signatures here)