Update EIP-7761: clarify how EXTCODETYPE deals with EOF versions #9591
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the EIP spec states that
2is returned on EOFv1 (starting with0xef0001) targets, but doesn't commit to returning something else for potential future versions of EOF.We can fix this two fold:
1/ commit to a particular return value scheme (simplest being return
3for EOFv2, but there are alternatives discussed on the EthMag thread linked)2/ (this PR) commit to not ever return anything else than
2for any version of EOF contract, at least if executed in an EOFv1 code.