Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-6997: Move to Last Call #7177

Closed
wants to merge 7 commits into from
+2 −2
Closed

Update EIP-6997: Move to Last Call #7177

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
937985f
Move to Review
eduardJobchain Jun 2, 2023
a055c65
Merge branch 'master' into master
eduardfina Jun 2, 2023
4744df2
Merge branch 'ethereum:master' into master
eduardfina Jun 5, 2023
d74c281
Merge branch 'ethereum:master' into master
eduardfina Jun 13, 2023
0662491
Last Call status
eduardfina Jun 13, 2023
63fc6e9
Merge branch 'master' into master
eduardfina Jun 19, 2023
eddf855
Merge branch 'ethereum:master' into master
eduardfina Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions EIPS/eip-6997.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
description: A new validation step for transfer and approve calls, achieving a security step in case of stolen wallet.
author: Eduard López i Fina (@eduardfina)
discussions-to: https://ethereum-magicians.org/t/erc721-with-a-validation-step/14071
status: Review
status: Last Call

Check failure on line 7 in EIPS/eip-6997.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `last-call-deadline` is required when `status` is `Last Call` 

error[preamble-req-last-call-deadline]: preamble header `last-call-deadline` is required when `status` is `Last Call`
 --> EIPS/eip-6997.md:7:1
  |
7 | status: Last Call
  | ----------------- info: defined here
  |
  = help: see https://ethereum.github.io/eipw/preamble-req-last-call-deadline/
type: Standards Track
category: ERC
created: 2023-05-07
Expand Down Expand Up @@ -43,7 +43,7 @@

When validating a `TransferValidation` or `ApprovalValidation` the valid field MUST be set to true and MUST NOT be validated again.

The operations that validate a `TransferValidation` SHALL change the ownership of the NFT or enable the approval.
The operations that validate a `TransferValidation` SHALL change the ownership of the NFT.

The operations that validate an `ApprovalValidation` SHALL enable the approval.

Expand Down
Loading