Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Versioned TokenIDs for Dynamic NFTs #6912

Closed
wants to merge 11 commits into from

Conversation

emo-eth
Copy link

@emo-eth emo-eth commented Apr 19, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@emo-eth emo-eth requested a review from eth-bot as a code owner April 19, 2023 20:22
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Apr 19, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 19, 2023

File EIPS/eip-6912.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot changed the title Add EIP: Versioned TokenId Standard Add EIP: Versioned TokenId Standard for Dynamic NFTs Apr 19, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Apr 19, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 19, 2023
@eth-bot eth-bot changed the title Add EIP: Versioned TokenId Standard for Dynamic NFTs Add EIP: Versioned TokenIDs for Dynamic NFTs Apr 19, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 19, 2023
@github-actions
Copy link

The commit e1169f6 (as a parent of 76681f6) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Apr 19, 2023
@emo-eth emo-eth force-pushed the emo.eth/versioned-token-ids branch from 9715d77 to 5b36079 Compare April 21, 2023 16:40
---
eip: 6912
title: Versioned TokenIDs for Dynamic NFTs
description: A minimal, backwards-compatible specification for versioned token IDs for dynamic NFTs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your description doesn't really add any information over the title. Answering the question of "what is a versioned token ID" would be a reasonable goal for your description.


This EIP proposes an extension to the [ERC-721](./eip-721.md) non-fungible token standard by introducing a Versioned TokenId standard for "dynamic" NFTs with on or offchain properties that may change over time. The new "versioned tokenId" is meant to track both the "identifier" of a token as well as its current "version number" so that old outstanding orders and approvals for updated tokens are automatically invalidated.

A `uint256 versionedTokenId` MUST encode both the true token "identifier" along with a "version number". Encoding, storage, and retrieval specific details should be left up to individual token implementations, and this EIP does not make specific recommendations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't introduce any requirements ("MUST") outside of the Specification section. Give an overview in the abstract, but don't use the RFC 2119 keywords.

@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants