Add EIP: Redeemable Tokens #6732

lucazffz · 2023-03-20T19:29:07Z

A proposal for redeemable tokens.

eth-bot · 2023-03-20T19:29:39Z

File `EIPS/eip-6732.md`

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

abcoathup · 2023-03-21T02:19:29Z

EIP editors assign an EIP number (generally the PR number, but the decision is with the editors) (from: EIP1)

I couldn't see where an EIP editor assigned ERC4365.

Earlier #6731 PR was closed

lucazffz · 2023-03-21T13:08:20Z

@abcoathup Oh okay, I must have missed that. I apologize. I will remove the EIP number. However, it would be easier to keep this number since it's not taken and used extensively in the reference implementation code. I can absolutely change that if necessary.

Pandapip1

Please fix the CI errors.

We're experimenting with a new automated system to assign EIP numbers. Feel free to ignore the eip walidator error about the missing eip header for now.

Avoid self-references. Simply refer to the current eip as "this EIP", rather than by "EIP-X". For the code, simply use descriptive names for the classes. It's much more readable than an opaque number, anyway.

Pandapip1

You get the drill.

EIPS/eip-draft_title_abbrev.md

Co-authored-by: Gavin John <[email protected]>

EIPS/eip-draft_title_abbrev.md

Co-authored-by: Andrew B Coathup <[email protected]>

github-actions · 2023-03-28T10:05:34Z

The commit 4699fd2 (as a parent of 1a84d4a) contains errors.
Please inspect the Run Summary for details.

Pandapip1 · 2023-03-29T13:52:50Z

@eth-bot rerun

SamWilsn

In addition to my other comments, would you mind reducing your reference implementation down to something more minimal? At minimum you should remove any of the OZ source. The readers can find those implementations themselves.

Generally the reference implementation should be one or two files to illustrate your proposal, and not a fully working production contract.

EIPS/eip-6732.md

SamWilsn · 2023-04-18T15:58:48Z

EIPS/eip-6732.md

+
+## Reference Implementation
+
+- [Reference implementation](../assets/eip-6732/)


The markdown renderer probably won't let you link to the whole directory. We normally recommend linking to the readme.

Do you mean the reference implementation's readme? If I should remove the migrations and slim the implementation down I suppose I should also remove the reference implementation's readme since it's not necessary at that point. Correct?

Yeah, if you cram the whole reference implementation into a single file, just link to that. If not, you can make a README.md that's just a manual listing of files:

# ERC-XXXX Reference Implementation * [SomeContract.sol](./SomeContract.sol) * [MagicInterface.sol](./MagicInterface.sol)

SamWilsn · 2023-04-18T15:59:07Z

assets/eip-6732/README.md

+truffle deploy
+```
+
+However, dont forget to link Ganache to the project (tutorial [here](https://trufflesuite.com/docs/ganache/how-to/link-a-truffle-project/)), alternatively create a Ganache quickstart workspace and match the server host and port in `truffle-config.js`.


You'll need to remove external links from your reference implementation as well.

SamWilsn · 2023-04-18T15:59:19Z

assets/eip-6732/contracts/.gitkeep

Remove this file please.

SamWilsn · 2023-04-18T15:59:53Z

assets/eip-6732/contracts/Migrations.sol

The reference implementation shouldn't need migrations. It shouldn't be a fully working project, just an illustrative example without any extra code.

Would it be sufficient to keep the files under the examples and token folders and remove the rest including utils and migrations?

That sounds reasonable, yes.

Co-authored-by: Sam Wilson <[email protected]>

SamWilsn

You'll also still need to remove external links and build files from your reference implementation.

SamWilsn · 2023-09-13T21:25:33Z

EIPS/eip-6732.md

+
+- Implementers SHOULD NOT allow tokens to be minted if total supply exceeds max supply.
+- Implementers SHOULD increment total supply upon minting and decrement upon burning.
+- Implementers are RECOMMENDED to override the `_beforeMint` hook to increment total supply upon minting and decrement upon burning.


The _beforeMint function is part of the reference implementation, not the specification itself. The Specification section should be understandable on its own without the other sections, while the reference implementation should help to clarify what's in the the Specification section.

Suggested change

- Implementers are RECOMMENDED to override the `_beforeMint` hook to increment total supply upon minting and decrement upon burning.

github-actions · 2023-09-28T00:16:42Z

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

SamWilsn · 2023-10-25T22:05:39Z

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

Create eip-4365.md

d883c80

lucazffz requested a review from eth-bot as a code owner March 20, 2023 19:29

github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Mar 20, 2023

eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Mar 20, 2023

github-actions bot added the w-ci Waiting on CI to pass label Mar 20, 2023

Remove ERC4365Badge extension and add reference implementation

9eff3ff

lucazffz closed this Mar 21, 2023

lucazffz reopened this Mar 21, 2023

lucazffz changed the title ~~Add EIP-4365: Redeemable Tokens~~ Add EIP-X: Redeemable Tokens Mar 21, 2023

Update eip-4365.md

3a09967

github-actions bot added the e-number Waiting on EIP Number assignment label Mar 21, 2023

lucazffz changed the title ~~Add EIP-X: Redeemable Tokens~~ Add Redeemable Tokens Mar 21, 2023

lucazffz added 2 commits March 21, 2023 15:02

Fix EIP errors

b8f41f6

Fix EIP errors

b376862

lucazffz changed the title ~~Add Redeemable Tokens~~ Add eip-draft_title_abbrev.md: Redeemable Tokens Mar 21, 2023

lucazffz changed the title ~~Add eip-draft_title_abbrev.md: Redeemable Tokens~~ Add eip-draft_title_abbrev: Redeemable Tokens Mar 21, 2023

github-actions bot removed the w-ci Waiting on CI to pass label Mar 21, 2023

lucazffz changed the title ~~Add eip-draft_title_abbrev: Redeemable Tokens~~ Add Redeemable Tokens Mar 21, 2023

Fix EIP errors

1321932

github-actions bot added w-ci Waiting on CI to pass and removed c-new Creates a brand new proposal e-number Waiting on EIP Number assignment labels Mar 21, 2023

lucazffz added 2 commits March 21, 2023 15:20

Fix EIP errors

661fadb

Fix reference implementation link

a2b7ac3

Pandapip1 suggested changes Mar 22, 2023

View reviewed changes

eth-bot changed the title ~~Add Redeemable Tokens~~ Add EIP: Redeemable Tokens Mar 22, 2023

Pandapip1 suggested changes Mar 22, 2023

View reviewed changes

EIPS/eip-draft_title_abbrev.md Outdated Show resolved Hide resolved

EIPS/eip-draft_title_abbrev.md Outdated Show resolved Hide resolved

EIPS/eip-draft_title_abbrev.md Outdated Show resolved Hide resolved

EIPS/eip-draft_title_abbrev.md Outdated Show resolved Hide resolved

lucazffz and others added 3 commits March 23, 2023 10:25

Apply suggestions from code review

949213d

Co-authored-by: Gavin John <[email protected]>

Change name from ERC4365 to RedeemableToken

13dd05b

Fix minor grammatical issues

47cd39a

abcoathup reviewed Mar 23, 2023

View reviewed changes

EIPS/eip-draft_title_abbrev.md Outdated Show resolved Hide resolved

Update EIPS/eip-draft_title_abbrev.md

34e555e

Co-authored-by: Andrew B Coathup <[email protected]>

github-actions bot added the c-new Creates a brand new proposal label Mar 24, 2023

mspaansen previously approved these changes Mar 25, 2023

View reviewed changes

lucazffz changed the title ~~Add EIP: Redeemable Tokens~~ Add EIP-6732: Redeemable Tokens Mar 28, 2023

Change to assigned eip number

4699fd2

lucazffz dismissed mspaansen’s stale review via 4699fd2 March 28, 2023 10:00

Update eip-6732.md

54cd1ff

github-actions bot removed the w-ci Waiting on CI to pass label Mar 28, 2023

eth-bot changed the title ~~Add EIP-6732: Redeemable Tokens~~ Add EIP: Redeemable Tokens Mar 29, 2023

poojaranjan mentioned this pull request Apr 18, 2023

EIP Editing Office Hour Meeting 15 ethcatherders/EIPIP#225

Closed

23 tasks

SamWilsn reviewed Apr 18, 2023

View reviewed changes

lucazffz and others added 4 commits April 20, 2023 11:58

Update EIPS/eip-6732.md

68a8c0a

Co-authored-by: Sam Wilson <[email protected]>

Update EIPS/eip-6732.md

f2dda34

Co-authored-by: Sam Wilson <[email protected]>

Update eip-6732.md

1001749

Update EIPS/eip-6732.md

1c2c740

SamWilsn requested changes Sep 13, 2023

View reviewed changes

6732: Minor tweaks

580a4a7

github-actions bot added the w-stale Waiting on activity label Sep 28, 2023

SamWilsn closed this Oct 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP: Redeemable Tokens #6732

Add EIP: Redeemable Tokens #6732

lucazffz commented Mar 20, 2023 •

edited by github-actions bot

Loading

eth-bot commented Mar 20, 2023 •

edited

Loading

abcoathup commented Mar 21, 2023 •

edited

Loading

lucazffz commented Mar 21, 2023

Pandapip1 left a comment •

edited

Loading

Pandapip1 left a comment

github-actions bot commented Mar 28, 2023

Pandapip1 commented Mar 29, 2023

SamWilsn left a comment

SamWilsn Apr 18, 2023

lucazffz Apr 20, 2023 •

edited

Loading

SamWilsn May 4, 2023

SamWilsn Apr 18, 2023

SamWilsn Apr 18, 2023

SamWilsn Apr 18, 2023

lucazffz Apr 20, 2023

SamWilsn May 4, 2023

SamWilsn left a comment

SamWilsn Sep 13, 2023

github-actions bot commented Sep 28, 2023

SamWilsn commented Oct 25, 2023


		## Reference Implementation

		- [Reference implementation](../assets/eip-6732/)

Add EIP: Redeemable Tokens #6732

Add EIP: Redeemable Tokens #6732

Conversation

lucazffz commented Mar 20, 2023 • edited by github-actions bot Loading

eth-bot commented Mar 20, 2023 • edited Loading

File EIPS/eip-6732.md

abcoathup commented Mar 21, 2023 • edited Loading

lucazffz commented Mar 21, 2023

Pandapip1 left a comment • edited Loading

Choose a reason for hiding this comment

Pandapip1 left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 28, 2023

Pandapip1 commented Mar 29, 2023

SamWilsn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucazffz Apr 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SamWilsn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 28, 2023

SamWilsn commented Oct 25, 2023

lucazffz commented Mar 20, 2023 •

edited by github-actions bot

Loading

eth-bot commented Mar 20, 2023 •

edited

Loading

File `EIPS/eip-6732.md`

abcoathup commented Mar 21, 2023 •

edited

Loading

Pandapip1 left a comment •

edited

Loading

lucazffz Apr 20, 2023 •

edited

Loading