Skip to content

op-test-sequencer: support for L1 reorgs #16105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: nonsense/reset-local-unsafe
Choose a base branch
from

Conversation

nonsense
Copy link
Contributor

@nonsense nonsense commented May 23, 2025

Description

This PR is:

  1. Adding builder/signer/publisher/sequencer for L1 to the op-test-sequencer, enabling it to produce L1 reorgs
  2. Adding a test that triggers a L1 reorg, and checks if eventually the L2 chain is also reorged and uses valid L1Origin references, and does not reference reorged L1 blocks.

Tests

TestL2ReorgAfterL1Reorg

Additional context

Related: #16052

Metadata

Fixes: #16061
Partially fixes: #15331

TODO

  • refactor L1 builder / support in op-test-sequencer
  • fix docker build for op-test-sequencer
  • add support for reorgs for L1 blocks referenced by safe L2 block (via L1Origin)

Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 73.22581% with 83 lines in your changes missing coverage. Please review.

Project coverage is 44.01%. Comparing base (43c7084) to head (4fd48ac).

Files with missing lines Patch % Lines
...r/sequencer/backend/work/builders/l1builder/job.go 69.00% 41 Missing and 12 partials ⚠️
op-service/sources/sequencer_control_client.go 0.00% 14 Missing ⚠️
...encer/backend/work/builders/l1builder/l1builder.go 74.07% 6 Missing and 1 partial ⚠️
op-devstack/sysext/system.go 0.00% 4 Missing ⚠️
...sequencer/sequencer/backend/work/config/builder.go 0.00% 2 Missing ⚠️
...backend/work/signers/noopsigner/noopsignedblock.go 0.00% 2 Missing ⚠️
op-devstack/sysgo/system.go 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (43c7084) and HEAD (4fd48ac). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (43c7084) HEAD (4fd48ac)
contracts-bedrock-tests 1 0
Additional details and impacted files
@@                       Coverage Diff                        @@
##           nonsense/reset-local-unsafe   #16105       +/-   ##
================================================================
- Coverage                        96.24%   44.01%   -52.23%     
================================================================
  Files                              106     1204     +1098     
  Lines                             4575   101150    +96575     
================================================================
+ Hits                              4403    44518    +40115     
- Misses                             172    53114    +52942     
- Partials                             0     3518     +3518     
Flag Coverage Δ
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-devstack/dsl/l1_el.go 72.41% <100.00%> (ø)
op-devstack/dsl/l2_network.go 84.32% <100.00%> (ø)
op-devstack/shim/sequencer.go 81.81% <100.00%> (ø)
op-devstack/stack/sequencer.go 40.00% <ø> (ø)
op-devstack/sysgo/l1_nodes.go 96.05% <100.00%> (ø)
op-devstack/sysgo/sequencer.go 100.00% <100.00%> (ø)
...equencer/backend/work/builders/l1builder/config.go 100.00% <100.00%> (ø)
...equencer/backend/work/signers/noopsigner/signer.go 100.00% <100.00%> (ø)
op-devstack/sysgo/system.go 55.12% <50.00%> (ø)
...sequencer/sequencer/backend/work/config/builder.go 40.00% <0.00%> (ø)
... and 5 more

... and 1295 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from 3493f6a to f0a44bc Compare May 23, 2025 19:42
@nonsense nonsense force-pushed the nonsense/reset-local-unsafe-with-test branch from f0a44bc to 5bcf48d Compare May 27, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant