refactor(test): cleanup of /libraries test structure and documentation #16103
+507
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- consolidate test initialization into a single StaticConfig_TestInit contract - organize individual test functions into separate contracts inheriting from TestInit - refactor test function names to follow naming convention - add @title and @notice tags to all test contracts - convert @dev tags to @notice where appropriate - ensure comment lines stay within 100 character limit
- consolidate test initialization into a single GasPayingToken_TestInit contract - organize individual test functions into separate contracts inheriting from TestInit - group tests not directly tied to a base contract function into GasPayingToken_Unclassified_Test - refactor test function names to follow naming convention - add @title and @notice tags to all test contracts - convert @dev tags to @notice where appropriate - ensure comment lines stay within 100 character limit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16103 +/- ##
============================================
+ Coverage 82.34% 96.24% +13.89%
============================================
Files 161 106 -55
Lines 8812 4575 -4237
============================================
- Hits 7256 4403 -2853
+ Misses 1416 172 -1244
+ Partials 140 0 -140
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…tion - consolidate test initialization into a single TransientContext_TestInit contract - organize individual test functions into separate contracts inheriting from TestInit - group tests not directly tied to a base contract function into TransientContext_Unclassified_Test - add @title and @notice tags to all test contracts - ensure comment lines stay within 100 character limit
- consolidate test initialization into a single SafeCall_TestInit contract - organize individual test functions into separate contracts inheriting from TestInit - refactor test function names to follow naming convention - add @title and @notice tags to all test contracts - convert @dev tags to @notice where appropriate - ensure comment lines stay within 100 character limit
- consolidate test initialization into a single Blueprint_TestInit contract - organize individual test functions into separate contracts inheriting from TestInit - group tests not directly tied to a base contract function or are testing multiple functions into Blueprint_Unclassified_Test - refactor test function names to follow naming convention - reorder test functions to match the order of definitions in the base contract - add @title and @notice tags to all test contracts - ensure comment lines stay within 100 character limit
aliersh
force-pushed
the
ari/libraries-tests-cleanup
branch
from
17eacb1 to
872f962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a portion of the test suite within the
/librariesfolder as part of a broader effort to standardize structure, documentation, and formatting across the codebase.Changes applied to each file:
*_TestInitcontractsTestInit@titleand@noticetags to all test contracts@noticecomments describing expected behavior under test@devtags with@noticewhere appropriateProgress
Refactored 10 of 15 test files (66.7% complete)
More
/librariesfiles will be added to this PR progressively until the full folder is covered.