refactor(test): cleanup of /dispute test structure and documentation #16088
+459
−371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- consolidate test initialization into a single DelayedWETH_TestInit contract - organize individual test functions into separate contracts inheriting from TestInit - add @title and @notice tags to all test contracts - convert @dev tags to @notice where appropriate - ensure comment lines stay within 100 character limit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16088 +/- ##
============================================
+ Coverage 47.02% 96.24% +49.21%
============================================
Files 1360 106 -1254
Lines 109457 4575 -104882
============================================
- Hits 51472 4403 -47069
+ Misses 54337 172 -54165
+ Partials 3648 0 -3648
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
- consolidate test initialization into a single LibPosition_TestInit contract - organize individual test functions into separate contracts inheriting from TestInit - group tests not directly tied to a base contract function into LibPosition_Unclassified_Test - refactor test function names to follow naming convention - add @title and @notice tags to all test contracts - ensure comment lines stay within 100 character limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a portion of the test suite within the
/disputefolder as part of a broader effort to standardize structure, documentation, and formatting across the codebase.Changes applied to each file:
*_TestInitcontractsTestInit@titleand@noticetags to all test contracts@noticecomments describing expected behavior under test@devtags with@noticewhere appropriateProgress
Refactored 3 of 10 test files (30.0% complete)
More
/disputefiles will be added to this PR progressively until the full folder is covered.