feat/interop: add conditional deployment of L1BlockInterop

[0xfuturistic]

enables the deployment of L1BlockInterop if the interop flag is set to true

[coderabbitai]

Warning

Rate Limit Exceeded

@0xfuturistic has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 45 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between d98560b and d051f37.

Walkthrough

The L2Genesis contract's setL1Block function now includes a check for the cfg.useInterop() condition. If this condition is true, it employs additional logic to fetch and set the implementation code using vm.etch and related functions. This update ensures that the implementation code is correctly set based on the configuration.

Changes

File Path	Change Summary
.../contracts-bedrock/scripts/L2Genesis.s.sol	Added conditional logic in setL1Block to check cfg.useInterop() before setting implementation code. Included logic to fetch code using vm.etch if cfg.useInterop() is true.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[semgrep-app]

Semgrep found 4 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/src/L1/SystemConfigInterop.sol
  • L20 - Triage
• packages/contracts-bedrock/src/L1/SystemConfig.sol
  • L119 - Triage
• packages/contracts-bedrock/src/L1/OptimismPortalInterop.sol
  • L19 - Triage
• packages/contracts-bedrock/src/L1/OptimismPortal.sol
  • L132 - Triage

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

Semgrep found 3 golang_fmt_errorf_no_params findings:

• op-node/rollup/types.go
  • L416 - Triage
  • L419 - Triage
  • L422 - Triage

No fmt.Errorf invocations without fmt arguments allowed

_{Ignore this finding from golang_fmt_errorf_no_params.}

Semgrep found 4 ban-common-hex2bytes findings:

• op-challenger/game/fault/contracts/faultdisputegame_test.go
  • L188 - Triage
  • L197 - Triage
  • L206 - Triage
  • L215 - Triage

Found banned use of common.Hex2Bytes. Use common.FromHex instead.

_{Ignore this finding from ban-common-hex2bytes.}

Semgrep found 1 avoid-bind-to-all-interfaces finding:

• indexer/node/client_test.go
  • L14 - Triage

Detected a network listener listening on 0.0.0.0 or an empty string. This could unexpectedly expose the server publicly as it binds to all available interfaces. Instead, specify another IP address that is not 0.0.0.0 nor the empty string.

_{Ignore this finding from avoid-bind-to-all-interfaces.}

Semgrep found 1 todos_require_linear finding:

• op-node/rollup/derive/plasma_data_source.go
  • L71 - Triage

Please create a GitHub ticket for this TODO.

_{Ignore this finding from todos_require_linear.}

Semgrep found 1 err-nil-check finding:

• indexer/client/client.go
  • L119-123 - Triage

superfluous nil err check before return

_{Ignore this finding from err-nil-check.}

[semgrep-app]

Semgrep found 3 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/src/libraries/StaticConfig.sol
  • L21 - Triage
  • L36 - Triage
  • L50 - Triage

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}