rif token on rsk mainnet

[alebanzas]

Implements EIP-1191 for checksum, extending EIP-55

[ligi]

Thanks! But to merge it the address must be in ERC-55 (filename and address field)

via CI: The address is not valid with ERC-55 checksum 0x2aCc95758f8b5F583470bA265Eb685a8f45fC9D5 expected: 0x2AcC95758f8b5F583470ba265EB685a8F45fC9D5

[ligi]

seems related: komputing/KEthereum#80

[jonathansmirnoff]

@ligi because of the PR: komputing/KEthereum#85 was merged, I wanted to know how we can forward with this PR. Do I have to add the chainId? Thanks!

[ligi]

we have the chainId here: https://github.com/ethereum-lists/tokens/blob/master/src/main/kotlin/org/ethereum/lists/tokens/Main.kt#L13 no need to put it in the json.
What needs to happen: add a new field address_eip1191 in the CI scripts / README. We cannot directly change the behavior of the address field as upstream projects might stumble over it.
I will merge PRs implementing this - but I will not do them as I think EIP1191 is a horrible idea actualy.

[jonathansmirnoff]

Thanks for your response and I understand that you don't like the EIP1191.
I need more clarification about the steps that I should do:

• Add RSK chainId here: https://github.com/ethereum-lists/tokens/blob/master/src/main/kotlin/org/ethereum/lists/tokens/Main.kt#L13
• Update CI Script: Should I update this file https://github.com/ethereum-lists/tokens/blob/master/src/main/kotlin/org/ethereum/lists/tokens/TokenChecker.kt or here https://github.com/ethereum-lists/tokens/blob/master/src/main/kotlin/org/ethereum/lists/tokens/model/Token.kt?

[ligi]

• Add RSK chainId here: https://github.com/ethereum-lists/tokens/blob/master/src/main/kotlin/org/ethereum/lists/tokens/Main.kt#L13

as far as I see it is already there

• Update CI Script: Should I update this file https://github.com/ethereum-lists/tokens/blob/master/src/main/kotlin/org/ethereum/lists/tokens/TokenChecker.kt?

yes

[jonathansmirnoff]

@ligi because the PR #339 has been merged, do you think this PR can be merged? Thanks!

[ligi]

sure - can you rebase to master?

[jonathansmirnoff]

sure - can you rebase to master?

Sure, I'll try to do it. If I can't do it because I didn't make this PR, I'll make another PR and ask to close this.

[jonathansmirnoff]

Done! :)

[ligi]

merged ;-)

[jonathansmirnoff]

Thanks so much for your help in this process!