-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add selfcontained raftexample #67
Conversation
@ahrtr @ptabor @serathius PTAL |
I ran the one instance locally and it is as expected
|
used
|
ed5deb5
to
da6bac1
Compare
Signed-off-by: Mustafa Elbehery <[email protected]> Signed-off-by: Mustafa Elbehery <[email protected]>
Signed-off-by: Mustafa Elbehery <[email protected]>
Signed-off-by: Mustafa Elbehery <[email protected]> Signed-off-by: Mustafa Elbehery <[email protected]>
Signed-off-by: Mustafa Elbehery <[email protected]> Signed-off-by: Mustafa Elbehery <[email protected]>
Signed-off-by: Mustafa Elbehery <[email protected]>
Signed-off-by: Mustafa Elbehery <[email protected]> Signed-off-by: Mustafa Elbehery <[email protected]>
Signed-off-by: Mustafa Elbehery <[email protected]> Signed-off-by: Mustafa Elbehery <[email protected]>
Signed-off-by: Mustafa Elbehery <[email protected]> Signed-off-by: Mustafa Elbehery <[email protected]>
Signed-off-by: Mustafa Elbehery <[email protected]>
@ptabor @ahrtr @serathius Hello ✋🏽 I have resolved the conflicts, would you kindly review ? |
Please read #2 (comment), thx |
Thanks @ahrtr for your review @mhagger Hello ✋🏽 Shall we refurbish etcd-io/etcd#15471 and remove any etcd related context ? Also I think this is more appropriate to be created against https://github.com/etcd-io/raft, please correct me if I am wrong :) |
@Elbehery: In Elbehery#1 I created a new version of etcd-io/etcd#15471 on top of this PR. I've got another patch series that does more work on top of Elbehery#1, but I haven't created a PR yet because PRs on top of PRs on top of a PR in a fork against the upstream repository is starting to get pretty unwieldy. I think that it would make sense to continue working incrementally on top of this branch until we have replaced all of the extraneous etcd code, and only then get final review and merge it into the main branch of |
replaced with #153 |
resolves #2
Signed-off-by: Mustafa Elbehery [email protected]