Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable thelper linter #19271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

enables and fixes thelper linter issues.

Notice that only naming rules are activated here.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 force-pushed the golangci-lint/thelper branch from 693c68d to 168f7db Compare January 25, 2025 10:09
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.76%. Comparing base (8731c31) to head (168f7db).

Files with missing lines Patch % Lines
server/storage/wal/testing/waltesting.go 46.66% 8 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/backend/testing/betesting.go 87.50% <100.00%> (ø)
server/storage/wal/testing/waltesting.go 60.86% <46.66%> (ø)

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19271      +/-   ##
==========================================
- Coverage   68.85%   68.76%   -0.10%     
==========================================
  Files         420      420              
  Lines       35680    35680              
==========================================
- Hits        24569    24534      -35     
- Misses       9689     9726      +37     
+ Partials     1422     1420       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8731c31...168f7db. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants