Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: address bridge unexported return issue #19105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manthanguptaa
Copy link
Contributor

@manthanguptaa manthanguptaa commented Dec 24, 2024

Introducing a new Bridge interface to resolve bridge unexported return issue

Part of #18370.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: manthanguptaa
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @manthanguptaa. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@manthanguptaa
Copy link
Contributor Author

manthanguptaa commented Dec 24, 2024

@ivanvc @jmhbnz requesting your review.

Also, I did push a signed commit but it still shows an unverified commit. I set up the GPG key for the same.

@manthanguptaa manthanguptaa force-pushed the tests-unexported-return branch from 2b8b165 to 0f6a30f Compare December 24, 2024 02:54
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (801dfc3) to head (0f6a30f).
Report is 65 commits behind head on main.

Additional details and impacted files

see 36 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19105      +/-   ##
==========================================
- Coverage   68.77%   68.76%   -0.01%     
==========================================
  Files         420      420              
  Lines       35623    35640      +17     
==========================================
+ Hits        24498    24507       +9     
- Misses       9699     9705       +6     
- Partials     1426     1428       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 801dfc3...0f6a30f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants