grpcproxy: use metadata instead of context withvalue in with client auth token #19033
+103
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to use metadata instead of
context.WithValue
to ensure each proxy watcher client has a new stream created with its token.Previously context.WithValue resulted in
streamKeyFromCtx
returning an empty string in the clientv3 watcher, causing stream reuse.When new clients connected to proxy after the token expired (token for the initial client which connected) the reused stream's context would still contain the expired token. This caused auth failures when
isWatchPermitted
on cluster checked the stream's context resulting in hanging proxy watcher clients.Issue can be reproduced by setting a low
--auth-token-ttl
on cluster and connect 1 client first to proxy and then connect a second one after token expired.Also adds increase of
watchersCoalescing
metric when watchers have been coalesced.