Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-11-18] Manual Dependency Bump #18932

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

This commit will bump dependency golang.org/x/crypto from 0.28.0 to 0.29.0

Signed-off-by: ArkaSaha30 <[email protected]>
…olang.org/grpc/otelgrpc from 0.56.0 to 0.57.0

This commit will bump dependency go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.56.0 to 0.57.0

Signed-off-by: ArkaSaha30 <[email protected]>
dependency: bump golang.org/x/net from 0.30.0 to 0.31.0

Signed-off-by: ArkaSaha30 <[email protected]>
This commit will bump dependency google.golang.org/protobuf from 1.35.1 to 1.35.2

Signed-off-by: ArkaSaha30 <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.70%. Comparing base (4186283) to head (5339444).
Report is 10 commits behind head on main.

Current head 5339444 differs from pull request most recent head 9c82a17

Please upload reports for the commit 9c82a17 to get more accurate results.

Additional details and impacted files

see 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18932      +/-   ##
==========================================
+ Coverage   68.65%   68.70%   +0.04%     
==========================================
  Files         420      420              
  Lines       35558    35558              
==========================================
+ Hits        24413    24429      +16     
+ Misses       9715     9700      -15     
+ Partials     1430     1429       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4186283...9c82a17. Read the comment docs.

---- 🚨 Try these New Features:

@ArkaSaha30
Copy link
Contributor Author

/retest-required

* Please add etcd_version annotation in *.proto file with next etcd version
* Run ./scripts/genproto.sh
push_pin
* Run ./scripts/update_proto_annotations.sh

Signed-off-by: ArkaSaha30 <[email protected]>
@ArkaSaha30
Copy link
Contributor Author

/retest-required

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ArkaSaha30

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ArkaSaha30, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit b1aa164 into etcd-io:main Nov 22, 2024
33 checks passed
@ahrtr
Copy link
Member

ahrtr commented Nov 22, 2024

We missed https://github.com/etcd-io/raft/releases/tag/v3.6.0-beta.0, @ArkaSaha30 could you raise a separate PR to bump it? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants