Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustness patch delete 2 #18907

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Robustness patch delete 2 #18907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fc84b8a
Unify operation refereces by using keyValue as key for put operation
serathius Nov 16, 2024
430741e
Use int for value stored in precomputed maps
serathius Nov 16, 2024
4c2bd31
Refactor watch response util functions for unit tests
serathius Jun 27, 2024
6d00e7b
Extract isUniqueOps function
serathius Nov 16, 2024
3ac6fe2
Count number of client puts and don't patch duplicated puts
serathius Nov 16, 2024
8c5efe0
Use persisted request count to determine if request was persisted
serathius Nov 16, 2024
3ed0f70
Reorder returnTime functions
serathius Nov 16, 2024
53cb02e
Unify functions for calculating return time
serathius Nov 16, 2024
8f4ad32
Use client put count for uniqness
serathius Jun 23, 2024
96c47e8
Allow duplicated put requests
serathius Oct 23, 2024
03ed9d1
Always set earliestReturnTime
serathius Nov 17, 2024
9da3da1
Group all maps into one patch input
serathius Nov 17, 2024
a2a5151
Wrap put imputs into context allowing for patching other operations
serathius Nov 17, 2024
3174983
Allow checking uniqness of any function
serathius Nov 17, 2024
5f4fc96
Patch unique delete operations
serathius Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions tests/robustness/validate/operations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,56 +46,56 @@ func TestValidateSerializableOperations(t *testing.T) {
},
{
Input: rangeRequest("a", "z", 2, 0),
Output: rangeResponse(1, keyValue("a", "1", 2)),
Output: rangeResponse(1, keyValueRevision("a", "1", 2)),
},
{
Input: rangeRequest("a", "z", 3, 0),
Output: rangeResponse(2,
keyValue("a", "1", 2),
keyValue("b", "2", 3),
keyValueRevision("a", "1", 2),
keyValueRevision("b", "2", 3),
),
},
{
Input: rangeRequest("a", "z", 4, 0),
Output: rangeResponse(3,
keyValue("a", "1", 2),
keyValue("b", "2", 3),
keyValue("c", "3", 4),
keyValueRevision("a", "1", 2),
keyValueRevision("b", "2", 3),
keyValueRevision("c", "3", 4),
),
},
{
Input: rangeRequest("a", "z", 4, 3),
Output: rangeResponse(3,
keyValue("a", "1", 2),
keyValue("b", "2", 3),
keyValue("c", "3", 4),
keyValueRevision("a", "1", 2),
keyValueRevision("b", "2", 3),
keyValueRevision("c", "3", 4),
),
},
{
Input: rangeRequest("a", "z", 4, 4),
Output: rangeResponse(3,
keyValue("a", "1", 2),
keyValue("b", "2", 3),
keyValue("c", "3", 4),
keyValueRevision("a", "1", 2),
keyValueRevision("b", "2", 3),
keyValueRevision("c", "3", 4),
),
},
{
Input: rangeRequest("a", "z", 4, 2),
Output: rangeResponse(3,
keyValue("a", "1", 2),
keyValue("b", "2", 3),
keyValueRevision("a", "1", 2),
keyValueRevision("b", "2", 3),
),
},
{
Input: rangeRequest("b\x00", "z", 4, 2),
Output: rangeResponse(1,
keyValue("c", "3", 4),
keyValueRevision("c", "3", 4),
),
},
{
Input: rangeRequest("b", "", 4, 0),
Output: rangeResponse(1,
keyValue("b", "2", 3),
keyValueRevision("b", "2", 3),
),
},
{
Expand All @@ -115,9 +115,9 @@ func TestValidateSerializableOperations(t *testing.T) {
{
Input: rangeRequest("a", "z", 4, 0),
Output: rangeResponse(3,
keyValue("c", "3", 4),
keyValue("b", "2", 3),
keyValue("a", "1", 2),
keyValueRevision("c", "3", 4),
keyValueRevision("b", "2", 3),
keyValueRevision("a", "1", 2),
),
},
},
Expand Down Expand Up @@ -149,7 +149,7 @@ func TestValidateSerializableOperations(t *testing.T) {
{
Input: rangeRequest("a", "z", 2, 0),
Output: rangeResponse(3,
keyValue("b", "2", 3),
keyValueRevision("b", "2", 3),
),
},
},
Expand All @@ -166,8 +166,8 @@ func TestValidateSerializableOperations(t *testing.T) {
{
Input: rangeRequest("a", "z", 2, 0),
Output: rangeResponse(3,
keyValue("a", "1", 2),
keyValue("b", "2", 3),
keyValueRevision("a", "1", 2),
keyValueRevision("b", "2", 3),
),
},
},
Expand Down Expand Up @@ -284,7 +284,7 @@ func errorResponse(err error) model.MaybeEtcdResponse {
}
}

func keyValue(key, value string, rev int64) model.KeyValue {
func keyValueRevision(key, value string, rev int64) model.KeyValue {
return model.KeyValue{
Key: key,
ValueRevision: model.ValueRevision{
Expand Down
Loading