Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use require instead of t.Fatal(err) in tests/integration package #18820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use require instead of t.Fatal(err) in tests/integration package #18820

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 1, 2024 •
edited
Loading

Description

This uses testify instead of testing for t.Fatal calls

Related to #18972

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35
Copy link
Contributor Author

/assign @spzala

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 08a5213 to 502fdc1 Compare November 1, 2024 10:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (40b856e) to head (116c8f3).

Additional details and impacted files

see 19 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #18820   +/-   ##
=======================================
  Coverage   68.77%   68.77%           
=======================================
  Files         420      420           
  Lines       35642    35642           
=======================================
+ Hits        24513    24514    +1     
- Misses       9703     9706    +3     
+ Partials     1426     1422    -4

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b856e...116c8f3. Read the comment docs.

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch 3 times, most recently from dac8a24 to 2d99225 Compare November 1, 2024 10:44
@mmorel-35
Copy link
Contributor Author

/assign @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Nov 1, 2024

/ok-to-test

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 2d99225 to dfa7b44 Compare November 1, 2024 13:29
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahrtr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch 2 times, most recently from 458fd16 to 3385c23 Compare November 1, 2024 13:40
@ahrtr
Copy link
Member

ahrtr commented Nov 3, 2024

Please try to breakdown the PR. We love small PR to make the review easy, although this PR is just mechanical changes.
Thanks

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 3385c23 to fa2bd5d Compare November 3, 2024 20:24
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from fa2bd5d to 44eda63 Compare November 3, 2024 20:24
@mmorel-35
Copy link
Contributor Author

/test pull-etcd-integration-1-cpu-amd64

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch 4 times, most recently from 94c8c18 to 6d896a0 Compare November 8, 2024 23:36
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch 2 times, most recently from c71b13a to 406698d Compare November 9, 2024 05:48
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35
Copy link
Contributor Author

/test pull-etcd-integration-1-cpu-amd64

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch 2 times, most recently from 8377832 to b6764b4 Compare November 9, 2024 22:22
@mmorel-35
Copy link
Contributor Author

I hold on this to apply gofumpt first

@mmorel-35 mmorel-35 marked this pull request as draft November 27, 2024 07:02
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from b6764b4 to efa2610 Compare November 29, 2024 10:09
@mmorel-35 mmorel-35 marked this pull request as ready for review November 29, 2024 10:11
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch 2 times, most recently from c4ff93b to 6c560ab Compare November 30, 2024 10:02
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 mentioned this pull request Nov 30, 2024
Open
14 tasks
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 6c560ab to 6a8afb9 Compare December 1, 2024 21:40
ahrtr
ahrtr requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please breakdown this PR to smaller ones, thanks

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 6a8afb9 to db069c0 Compare December 2, 2024 18:20
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from db069c0 to eb95361 Compare December 2, 2024 18:21
@mmorel-35 mmorel-35 requested a review from ahrtr December 2, 2024 18:36
@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from eb95361 to 21e141d Compare December 11, 2024 06:59
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 force-pushed the tests/integration/testifier/require-error branch from 21e141d to 116c8f3 Compare December 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr Awaiting requested review from ahrtr

Requested changes must be addressed to merge this pull request.

Assignees

@spzala spzala

@ahrtr ahrtr

Labels
area/testing ok-to-test size/XL
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmorel-35 @k8s-ci-robot @codecov-commenter @ahrtr @spzala