Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use require instead of t.Fatal(err) in tests/robustness package #18782

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 24, 2024

Description

This uses testify instead of testing for t.Fatal calls

Related to #18972

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35
Copy link
Contributor Author

/assign @spzala

@mmorel-35 mmorel-35 force-pushed the tests/testifier/require-error branch from c93c6f2 to 7d2388a Compare October 24, 2024 16:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (18eb5c6) to head (5babe03).

Current head 5babe03 differs from pull request most recent head 4017eba

Please upload reports for the commit 4017eba to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18782      +/-   ##
==========================================
+ Coverage   68.74%   68.77%   +0.03%     
==========================================
  Files         420      420              
  Lines       35512    35512              
==========================================
+ Hits        24411    24425      +14     
+ Misses       9671     9658      -13     
+ Partials     1430     1429       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18eb5c6...4017eba. Read the comment docs.

@jmhbnz
Copy link
Member

jmhbnz commented Oct 25, 2024

/ok-to-test

@mmorel-35
Copy link
Contributor Author

/retest

1 similar comment
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 force-pushed the tests/testifier/require-error branch from 7d2388a to 4017eba Compare October 26, 2024 06:15
@mmorel-35
Copy link
Contributor Author

/test pull-etcd-integration-1-cpu-amd64

@mmorel-35
Copy link
Contributor Author

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit c2bfbe8 into etcd-io:main Oct 30, 2024
33 checks passed
@mmorel-35 mmorel-35 deleted the tests/testifier/require-error branch October 31, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants