Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use require.NoError instead of t.Fatal(err) in tests package (part 1) #18753

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 19, 2024

Description

This uses testify instead of testing for
With

require.NoError(t, err)

require.Error(t, err)

instead of

if err != nil {
    t.Fatal(err)
}


if err == nil {
    t.Fatal(err)
}

Related to #18972

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35 mmorel-35 force-pushed the tests/testifier/require-error branch from 9e48967 to 1f1a46e Compare October 19, 2024 09:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (6d2b232) to head (c25c492).

Current head c25c492 differs from pull request most recent head 4da20aa

Please upload reports for the commit 4da20aa to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18753      +/-   ##
==========================================
+ Coverage   68.73%   68.77%   +0.03%     
==========================================
  Files         420      420              
  Lines       35510    35511       +1     
==========================================
+ Hits        24409    24421      +12     
+ Misses       9674     9664      -10     
+ Partials     1427     1426       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2b232...4da20aa. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Oct 19, 2024

@mmorel-35 Thanks for you constant effort, but please try to make each each such PR as small as possible, i.e < 100 lines of code change, so that each one can be approved & merged soon.

@mmorel-35
Copy link
Contributor Author

Good point ! I'll narrow the next PR to 100 lines of modifications

@mmorel-35
Copy link
Contributor Author

/assign @serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmorel-35, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member

Read through it, still +1 to what @ahrtr said. Don't optimize for number of lines changed, optimize for time it takes to review. That will help you land your work faster.

@serathius
Copy link
Member

/retest

@k8s-ci-robot
Copy link

@mmorel-35: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify 1f1a46e link true /test pull-etcd-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius
Copy link
Member

Please fix

robustness/model/deterministic_test.go:39:6: formatter: use require.NoErrorf (testifylint)
					require.NoError(t, err, "Failed to load state")

@mmorel-35 mmorel-35 force-pushed the tests/testifier/require-error branch from 1f1a46e to 4da20aa Compare October 24, 2024 09:48
@mmorel-35
Copy link
Contributor Author

Alright @serathius, I fixed the issue

@serathius serathius merged commit 2f36df8 into etcd-io:main Oct 24, 2024
15 checks passed
@mmorel-35 mmorel-35 deleted the tests/testifier/require-error branch October 24, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants