Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Execute the same validation for TXN to avoid data inconsistency #18680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Execute the same validation for TXN to avoid data inconsistency #18680

wants to merge 1 commit into from

Conversation

ArkaSaha30
Copy link
Contributor

This MR addresses the issue: #18667
Steps Ref: #18667 (comment)

  • create an e2e or integration test to reproduce the issue.
  • apply the patch (ahrtr@76ac23f) to ensure it fixes the issue.
  • evaluate the performance impact.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArkaSaha30
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArkaSaha30
Execute the same validation for TXN
d25513d 
This commit will ensure all members execute the same validation for TXN by not removing range requests from TXN.
Ref patch: ahrtr@76ac23f

Signed-off-by: ArkaSaha30 <[email protected]>
@ArkaSaha30 ArkaSaha30 force-pushed the range-req-inconsistency branch from b0a3307 to d25513d Compare October 5, 2024 04:44
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (7b429f9) to head (704e5cc).

❗ Current head 704e5cc differs from pull request most recent head d25513d

Please upload reports for the commit d25513d to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/server.go 81.02% <ø> (-0.11%) ⬇️

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18680      +/-   ##
==========================================
- Coverage   68.80%   68.78%   -0.03%     
==========================================
  Files         420      420              
  Lines       35540    35527      -13     
==========================================
- Hits        24455    24436      -19     
+ Misses       9666     9663       -3     
- Partials     1419     1428       +9

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b429f9...d25513d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArkaSaha30 @k8s-ci-robot @codecov-commenter