Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: remove arm64 jobs #844

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Oct 24, 2024

Remove the ARM64 jobs from GitHub workflows. Add a comment regarding the use of sudo in robustness tests.

Link to #848

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ivanvc
Copy link
Member Author

ivanvc commented Oct 24, 2024

/test all

@ivanvc
Copy link
Member Author

ivanvc commented Oct 24, 2024

/retest

@ivanvc
Copy link
Member Author

ivanvc commented Oct 24, 2024

/test pull-bbolt-robustness-arm64

1 similar comment
@ivanvc
Copy link
Member Author

ivanvc commented Oct 24, 2024

/test pull-bbolt-robustness-arm64

@k8s-ci-robot
Copy link

@ivanvc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-bbolt-robustness-arm64 1d7a65f link true /test pull-bbolt-robustness-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ivanvc
Copy link
Member Author

ivanvc commented Oct 25, 2024

@jmhbnz and I have been discussing the migration of robustness tests. The current issue is that we can't install xfsprogs in the container/prow job pod (https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_bbolt/844/pull-bbolt-robustness-arm64/1849591798716960768#). The reason is highly likely that the host node doesn't have the XFS filesystem. Therefore, we can't use dm-flakey.

As we will need help from the infra team, James suggests reaching out to k/test-infra and #sig-k8s-infra, which I'll do shortly.

@ivanvc
Copy link
Member Author

ivanvc commented Oct 29, 2024

@ahrtr, do you know (or provide some guidance on) why the 4 CPU tests with race are getting stuck? I could add a timeout, but that would make the job fail. I'm running them in Prow using the same command we used in the GitHub workflow.

Refer to https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_bbolt/846/pull-bbolt-test-4-cpu-race-arm64/1851126914400391168

@ahrtr
Copy link
Member

ahrtr commented Oct 29, 2024

do you know (or provide some guidance on) why the 4 CPU tests with race are getting stuck?

It looks like the test infra's issue, the test process somehow terminated or being blocked. 1000 concurrent goroutines shouldn't cause too much resource pressure. Not sure whether we can request some help from test-infra, probably they have more insight.

=== RUN TestSimulateNoFreeListSync_10000op_1000p
btesting.go:47: Opening bbolt DB at: /tmp/TestSimulateNoFreeListSync_10000op_1000p788848248/001/db

@ivanvc
Copy link
Member Author

ivanvc commented Oct 29, 2024

/help test

@ivanvc
Copy link
Member Author

ivanvc commented Oct 29, 2024

I'll mark this PR ready for review to check the triggered prow jobs.

@ivanvc ivanvc marked this pull request as ready for review October 29, 2024 16:44
Makefile Show resolved Hide resolved
@ivanvc
Copy link
Member Author

ivanvc commented Oct 29, 2024

@ahrtr, other than the comment on the TODO. The prow jobs triggered look fine, and they are all green.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit ad96be0 into etcd-io:main Oct 29, 2024
17 checks passed
@ivanvc ivanvc deleted the remove-arm-github-workflows branch October 29, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants