Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: old browser compatibility #59

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Conversation

rajyan
Copy link
Collaborator

@rajyan rajyan commented Feb 27, 2025

Description

Starting from Rust 1.82+, the multivalue and reference-types target features are enabled by default. However, these features are only supported in Chrome 96+.

To ensure broader browser compatibility, we will fix the Rust version to v1.81, allowing us to disable multivalue and reference-types.


Testing

  • Compiled the project locally with Rust v1.81 and confirmed that multivalue and reference-types are not used in the generated wasm_xlsxwriter.js.
  • Verified that installation and execution work successfully in Chrome 93.

@rajyan rajyan force-pushed the fix/old-browser-compatibility branch from 3b915bf to 9bf2dac Compare February 27, 2025 14:49
@rajyan rajyan marked this pull request as draft February 27, 2025 14:54
@rajyan rajyan force-pushed the fix/old-browser-compatibility branch from 9bf2dac to a2696f5 Compare February 27, 2025 14:58
@rajyan rajyan marked this pull request as ready for review February 27, 2025 15:03
@rajyan rajyan requested a review from kenkoooo February 27, 2025 15:03
@rajyan rajyan changed the title old browser compatibility feat: old browser compatibility Feb 27, 2025
Copy link
Member

@kenkoooo kenkoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rajyan rajyan merged commit f5d4db0 into main Feb 27, 2025
1 check passed
@rajyan rajyan deleted the fix/old-browser-compatibility branch February 27, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants