New clock/app: Time Harvester#4190
Merged
bobrippling merged 24 commits intoespruino:masterfrom Mar 12, 2026
Merged
Conversation
Also get rid of local module, which doesn't seem workable.
Collaborator
|
LGTM, let me know if you have any problems fixing the build problems :) |
Contributor
Author
|
@bobrippling Thanks for the fast review! I believe I've sorted that out. I wasn't able to run checks locally before, but seeing the actual CI helped me debug that I had skipped submodule checkout. |
Collaborator
|
My pleasure, thanks for the new app! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multifunctional clock based on Daisy. App loader preview; there is an extensive and hopefully correct README there, and install appears to work correctly.
Should be functional on a light theme, if less appealing. Tested only on B2 with 2v29 firmware, but shouldn't use any bleeding-edge features.
Emulator has obvious menu glitches that I can't seem to reproduce on actual hardware, even after deleting the settings file. As this is my first app, I'm not sure how much I should expect its behavior to diverge if doing some fairly complicated things.