[Sunrise Clock Info] Add setting for following sun phase#4189
Merged
bobrippling merged 10 commits intoespruino:masterfrom Mar 12, 2026
Merged
[Sunrise Clock Info] Add setting for following sun phase#4189bobrippling merged 10 commits intoespruino:masterfrom
bobrippling merged 10 commits intoespruino:masterfrom
Conversation
Implement settings menu for Sunrise Clock Info with auto rise and set option.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a settings menu and an “auto” mode for the Sunrise Clockinfo app so the displayed clockinfo switches between sunrise/sunset automatically based on the current time.
Changes:
- Added
settings.jsto expose an “Auto Rise & Set” toggle and persist it toclkinfosunrise.settings.json - Updated
clkinfo.jsto read the new setting and conditionally add either separate Sunrise/Sunset items or a single auto item - Bumped version to
0.06and updated metadata/storage entries and ChangeLog
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/clkinfosunrise/settings.js | New settings UI that toggles/persists auto mode |
| apps/clkinfosunrise/metadata.json | Version bump and inclusion of settings JS + settings JSON data file |
| apps/clkinfosunrise/clkinfo.js | Reads settings and adds an auto clockinfo entry when enabled |
| apps/clkinfosunrise/ChangeLog | Documents the new settings/auto behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RKBoss6
changed the title
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a settings menu with an auto mode where if the time passes the sunrise time, it shows sunset, and vice versa.