Skip to content

Sun and Moon Clock#4179

Open
eholstine wants to merge 31 commits intoespruino:masterfrom
eholstine:master
Open

Sun and Moon Clock#4179
eholstine wants to merge 31 commits intoespruino:masterfrom
eholstine:master

Conversation

@eholstine
Copy link

Sun and Moon Clock

A basic clock that displays the time, date and an indicator displaying a sun or moon.

Example:
Sun - 6:00 AM to 5:59 PM
Moon - 6:00 PM to 5:59 AM

screenshot (1) screenshot (2)

@eholstine eholstine marked this pull request as ready for review February 23, 2026 17:14
Copy link
Collaborator

@bobrippling bobrippling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you can fix the build errors and change the metadata

Note you don't need to recreate a pull request (like #4178), you can continue to change your branch and the changes will appear here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want a metadata file (example linked), rather than the info file here

@eholstine
Copy link
Author

eholstine commented Feb 23, 2026 via email

@bobrippling
Copy link
Collaborator

Thanks for the app - I fixed a few things with metadata and so on, there's just the icon left to sort if you could adjust the size (build error is here)

Error: JS icon sunmoonclk.img should be 48x48px (or slightly under) but is instead 0x0px

@eholstine
Copy link
Author

eholstine commented Feb 28, 2026 via email

@bobrippling
Copy link
Collaborator

You're welcome - the image converter will help you with generating the icon if you've not used it already. I'm afraid icons are a little opaque to me but if you get stuck let me know

@bobrippling
Copy link
Collaborator

Looks like the icon is initially all zeros:

icon: Uint8Array(5491) [
  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,

If you share the source and how you're using the icon converter I might be able to help you

@eholstine
Copy link
Author

eholstine commented Mar 1, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants