Conversation
bobrippling
left a comment
There was a problem hiding this comment.
LGTM, if you can fix the build errors and change the metadata
Note you don't need to recreate a pull request (like #4178), you can continue to change your branch and the changes will appear here
apps/sunmoonclk/sunmoonclk.info
Outdated
There was a problem hiding this comment.
We want a metadata file (example linked), rather than the info file here
|
I appreciate the feedback. Thanks. Sent from my iPhoneOn Feb 23, 2026, at 2:56 PM, Rob Pilling ***@***.***> wrote:
@bobrippling commented on this pull request.
LGTM, if you can fix the build errors and change the metadata
Note you don't need to recreate a pull request (like #4178), you can continue to change your branch and the changes will appear here
On apps/sunmoonclk/sunmoonclk.info:
We want a metadata file (example linked), rather than the info file here
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This reverts commit 4c4291e.
|
Thanks for the app - I fixed a few things with metadata and so on, there's just the icon left to sort if you could adjust the size (build error is here)
|
|
I appreciate your patience and assistance with my first project. I will work on getting the icon fixed as soon as possible. Hopefully my next project will go more smoothly. Thanks again.Sent from my iPhoneOn Feb 27, 2026, at 1:40 PM, Rob Pilling ***@***.***> wrote:bobrippling left a comment (espruino/BangleApps#4179)
Thanks for the app - I fixed a few things with metadata and so on, there's just the icon left to sort if you could adjust the size (build error is here)
Error: JS icon sunmoonclk.img should be 48x48px (or slightly under) but is instead 0x0px
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
You're welcome - the image converter will help you with generating the icon if you've not used it already. I'm afraid icons are a little opaque to me but if you get stuck let me know |
|
Looks like the icon is initially all zeros: If you share the source and how you're using the icon converter I might be able to help you |
|
Interesting, that’s not how it uploaded. I will take a look at it after I do some investigating. Thanks for the support.Sent from my iPhoneOn Mar 1, 2026, at 2:01 PM, Rob Pilling ***@***.***> wrote:bobrippling left a comment (espruino/BangleApps#4179)
Looks like the icon is initially all zeros:
icon: Uint8Array(5491) [
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
If you share the source and how you're using the icon converter I might be able to help you
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sun and Moon Clock
A basic clock that displays the time, date and an indicator displaying a sun or moon.
Example:
Sun - 6:00 AM to 5:59 PM
Moon - 6:00 PM to 5:59 AM