Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pad mask traceable #5680

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iamanigeeit
Copy link
Contributor

[skip ci] xs.shape[length_dim] sometimes returns tensor instead of int, causing different device error at torch.clamp(lengths, max=max_length). See (unresolved) issue at https://discuss.pytorch.org/t/x-shape-or-x-size-return-torch-size-with-elements-of-type-tensor/153136

This commit fixes it.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.12%. Comparing base (0854d6f) to head (449b455).

Files Patch % Lines
espnet/nets/pytorch_backend/nets_utils.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5680      +/-   ##
==========================================
+ Coverage   70.27%   76.12%   +5.84%     
==========================================
  Files         746      747       +1     
  Lines       69369    69411      +42     
==========================================
+ Hits        48752    52836    +4084     
+ Misses      20617    16575    -4042     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 62.91% <0.00%> (-0.01%) ⬇️
test_integration_espnet2 48.92% <33.33%> (?)
test_python_espnet1 18.32% <66.66%> (+<0.01%) ⬆️
test_python_espnet2 52.69% <33.33%> (+0.64%) ⬆️
test_utils 22.15% <0.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant