Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telnet + wrench #6717

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

telnet + wrench #6717

wants to merge 1 commit into from

Conversation

apbodrov
Copy link
Contributor

@apbodrov apbodrov commented May 9, 2024

What does this implement/fix?

Implementation of telnet cli

Types of changes

  • [+] New feature (non-breaking change which adds functionality)

Related issue or feature (if applicable): part of esphome/feature-requests#2707

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • [+] ESP32

Example entry for config.yaml:

# Example config.yaml
telnet:

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented May 9, 2024

Hey there @apbodrov,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@apbodrov"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@7ddcdab). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #6717   +/-   ##
======================================
  Coverage       ?   54.24%           
======================================
  Files          ?       50           
  Lines          ?     9581           
  Branches       ?     1688           
======================================
  Hits           ?     5197           
  Misses         ?     4060           
  Partials       ?      324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz
Copy link
Member

This is very niche and I think it should just live as an external_component

@apbodrov
Copy link
Contributor Author

This is very niche

This is the same SSH (It’s hard to call it niche), only for the poor. I want to implement through this interface such things as configuration in runtime, and such commands as, for example, dump_config to pull out the configuration from the flashed ESP (for me this is really a problem and I saw PR on this topic too)
This will require changes to the core part and can be useful to people (network equipment basically uses CLI insted of something else)

@jesserockz
Copy link
Member

I have no doubts that it could be useful to you and I know what telnet and SSH are. I am saying this in the context of having a telnet server available on a ESPHome device.

We are happy to accommodate smaller core changes that would he helpful to an external component as long as they do not interfere with normal usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants