Set FEATURE_API_AUDIO flag also if the speaker component is not used #6712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
In the current implementation of voice_assistant both flags FEATURE_API_AUDIO and FEATURE_SPEAKER are only set if the speaker component is used to play TTS responses. It is desirable to use the API for sending mic data to HA also when the media_player is used for TTS responses.
On the HA side, the TTS is only send via API if the FEATURE_SPEAKER is set, so from my understanding it is desirable to always set the FEATURE_API_AUDIO flag.
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: