Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set FEATURE_API_AUDIO flag also if the speaker component is not used #6712

Merged
merged 1 commit into from May 13, 2024

Conversation

gnumpi
Copy link
Contributor

@gnumpi gnumpi commented May 9, 2024

What does this implement/fix?

In the current implementation of voice_assistant both flags FEATURE_API_AUDIO and FEATURE_SPEAKER are only set if the speaker component is used to play TTS responses. It is desirable to use the API for sending mic data to HA also when the media_player is used for TTS responses.
On the HA side, the TTS is only send via API if the FEATURE_SPEAKER is set, so from my understanding it is desirable to always set the FEATURE_API_AUDIO flag.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented May 9, 2024

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (voice_assistant) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.24%. Comparing base (4d8b5ed) to head (a3dbea2).
Report is 555 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6712      +/-   ##
==========================================
+ Coverage   53.70%   54.24%   +0.53%     
==========================================
  Files          50       50              
  Lines        9408     9581     +173     
  Branches     1654     1688      +34     
==========================================
+ Hits         5053     5197     +144     
- Misses       4056     4060       +4     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will give it a test hopefully tomorrow and mark for a beta release

@jesserockz jesserockz added this to the 2024.5.0b4 milestone May 13, 2024
@jesserockz jesserockz merged commit 5ee4bf3 into esphome:dev May 13, 2024
57 checks passed
@jesserockz jesserockz mentioned this pull request May 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants