Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humidifier and Hygrostat Components #6678

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Jaco1990
Copy link

@Jaco1990 Jaco1990 commented May 5, 2024

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented May 5, 2024

Hey there @Jaco1990,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@Jaco1990"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.28%. Comparing base (4d8b5ed) to head (24e7e72).
Report is 508 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6678      +/-   ##
==========================================
+ Coverage   53.70%   54.28%   +0.58%     
==========================================
  Files          50       50              
  Lines        9408     9604     +196     
  Branches     1654     1687      +33     
==========================================
+ Hits         5053     5214     +161     
- Misses       4056     4066      +10     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paravoid
Copy link
Contributor

paravoid commented May 7, 2024

Hey @Jaco1990 - don't forget to link to the esphome-docs PR, as well as adjust the esphome-docs PR to point back to this one instead of #6591 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants