New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenTherm component #6645
base: dev
Are you sure you want to change the base?
Add OpenTherm component #6645
Conversation
Hey there @olegtarasov, CODEOWNERS = ["@olegtarasov"] And run (message by NeedsCodeownersLabel) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6645 +/- ##
==========================================
+ Coverage 53.70% 54.09% +0.38%
==========================================
Files 50 50
Lines 9408 9627 +219
Branches 1654 1701 +47
==========================================
+ Hits 5053 5208 +155
- Misses 4056 4092 +36
- Partials 299 327 +28 ☔ View full report in Codecov by Sentry. |
@jesserockz Hi! Can you please take a look at this pull request? It adds a new OpenTherm component to control various boilers through a hardware bridge. There is also another open pull request that implements a smaller subset of this functionality: #3921. I would argue that my PR should be accepted instead, for the following reasons:
|
What does this implement/fix?
This PR adds a new component that allows ESPHome to communicate with OpenTherm devices via a hardware bridge.
OpenTherm (OT) is a standard communications protocol used in central heating systems for the communication between a central heating appliances and a thermostatic controller.
EDIT: Right after finishing all the work of fixing linter errors, I saw a small “integration: opentherm“ label and discovered another open pull request: #3921 😂
I would still argue for my implementation (which is based on Arthur Rump's work here: https://github.com/arthurrump/esphome-opentherm) for the following reasons:
Types of changes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3800
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: