Add new variants in favour of #1649 #1677
Conversation
I'm sorry, I didn't know it would detect all variants as changed, I hope it's ok like this. If this pull request is doing any harm, please let me know. I don't see any harm in adding these variants as long as they're handed in the correct way.
|
Again, I'm sorry, I don't know how to fix the checks. There is one successful one and the rest failed, but I don't know what to do here. |
|
Increasing N_VOICES_LIST passes The current value seems arbitrary so it could be changed easily. If we simply increase the value, this same problem will occur later. Should we try to find a better solution by dynamically setting the array size? |
|
Hmm, don't know about that, but I think I kind of understand. So some file must be changed? Don't know how you would make that array dynamic, but if we don't want that problem coming up any longer, this sounds to me as the right solution. |
|
hello. I think this should solve the problems of eSpeak ng when more than 200 variants are added, remove some duplicates so that they do not enter into conflicts with the languages. Here I will share a package with the necessary variants to be added. Its 166 variants. |
I'm sorry, I didn't know it would detect all variants as changed, I hope it's ok like this. If this pull request is doing any harm, please let me know. I don't see any harm in adding these variants as long as they're handed in the correct way.