Fix dep import url of cjs module (close #592)

esm-dev · Apr 17, 2023 · a546b8b · a546b8b
1 parent aacd8f1
commit a546b8b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/server/build.go b/server/build.go
@@ -773,7 +773,11 @@ rebuild:
  }
  // if the dep is an es6 module
  if !marked && depNpm.Module != "" {
- cjsImportNames.Add("*?")
+ if depESM.HasExportDefault && len(depESM.NamedExports) == 1 {
+ cjsImportNames.Add("default")
+ } else {
+ cjsImportNames.Add("*?")
+ }
  marked = true
  }
  if !marked && includes(depESM.NamedExports, "__esModule") && depESM.HasExportDefault {

diff --git a/test/issue-592/issue-592.test.ts b/test/issue-592/issue-592.test.ts
@@ -0,0 +1,7 @@
+import { assertEquals } from "https://deno.land/[email protected]/testing/asserts.ts";
+
+import { createConnection } from "http://localhost:8080/[email protected]";
+
+Deno.test("issue #592", async () => {
+ assertEquals(typeof createConnection, "function");
+});